When using aggregation, additional fields should not be included in the grouping function

Adding screenshot.

Proposed fix.

Lendude, thanks for the reply.

This was the output of our SQL query from Views. Hopefully PostGres passes

SELECT commerce_order_report__mail.delta AS commerce_order_report__mail_delta, commerce_order_report__mail.langcode AS commerce_order_report__mail_langcode, commerce_order_report__mail.bundle AS commerce_order_report__mail_bundle, commerce_order_report__mail.mail_value AS commerce_order_report__mail_mail_value_1, commerce_order_report__amount.delta AS commerce_order_report__amount_delta, commerce_order_report__amount.langcode AS commerce_order_report__amount_langcode, commerce_order_report__amount.bundle AS commerce_order_report__amount_bundle, commerce_order_report__amount.amount_number AS commerce_order_report__amount_amount_number_1, commerce_order_report__amount.amount_currency_code AS commerce_order_report__amount_amount_currency_code, DATE_FORMAT(FROM_UNIXTIME(commerce_order_report.created), '%Y-%m') AS commerce_order_report_created, COUNT(commerce_order_report.order_id) AS commerce_order_report_order_id, COUNT(DISTINCT commerce_order_report__mail.mail_value) AS commerce_order_report__mail_mail_value, SUM(commerce_order_report__amount.amount_number) AS commerce_order_report__amount_amount_number, DATE_FORMAT((DATE_ADD('19700101', INTERVAL commerce_order_report.created SECOND) + INTERVAL -21600 SECOND), '%Y%m') AS commerce_order_report_created_month, MIN(commerce_order_report.report_id) AS report_id
FROM 
{commerce_order_report} commerce_order_report
LEFT JOIN {commerce_order_report__mail} commerce_order_report__mail ON commerce_order_report.report_id = commerce_order_report__mail.entity_id AND commerce_order_report__mail.deleted = '0'
LEFT JOIN {commerce_order_report__amount} commerce_order_report__amount ON commerce_order_report.report_id = commerce_order_report__amount.entity_id AND commerce_order_report__amount.deleted = '0'
WHERE commerce_order_report.type IN ('order_report')
GROUP BY commerce_order_report_created, commerce_order_report__mail_delta, commerce_order_report__mail_langcode, commerce_order_report__mail_bundle, commerce_order_report__mail_mail_value_1, commerce_order_report__amount_delta, commerce_order_report__amount_langcode, commerce_order_report__amount_bundle, commerce_order_report__amount_amount_number_1, commerce_order_report__amount_amount_currency_code, commerce_order_report_created_month
ORDER BY commerce_order_report_created_month DESC
LIMIT 11 OFFSET 0

But they are available as tokens right? So they can be printed? If that is so, I think we do need to consider BC.

I am not sure, I could check.

The only BC way forward that springs to mind is adding an option to the grouping settings that allow you to steer this: 'Use grouping type on additional fields', or something along those lines. Any other ideas?

I suppose "Use grouping type on additional fields" as a default makes sense. Then it's just a document step in Commerce Reports "select SUM or AVG, and uncheck this checkbox"

I'd love to have the same options from the EntityField handler, but Views overrides it to be a generic Numeric handler. Where you can specify additional fields to include (whereas with Numeric I think they're all automatically included?)

This is the only "quick" fix I can think of since there is no way to control the field handler when it is aggregated, from an implementation standpoint.