Problem/Motivation

After running a migration via the UI some helpful information is displayed but that include the message '8 upgrades failed' in green which surely should be in red. Or am I mistaken?

Proposed resolution

Display the failure in red

Remaining tasks

Write a patch
review
commit

User interface changes

Errors will be displayed in red not green.

CommentFileSizeAuthor
#14 before_patch.png53.8 KBvj
#14 after_patch.png50.78 KBvj
#4 show-errors-2974654-04.patch827 bytesjarodriguez
Selection_012.png8.04 KBquietone

Comments

quietone created an issue. See original summary.

quietone’s picture

quietone commented
Title: Migrate upgrade shows errros in green » Migrate upgrade shows errors in green

Fix typo in titoe

jarodriguez’s picture

jarodriguez commented
Assigned: Unassigned » jarodriguez
jarodriguez’s picture

jarodriguez commented
StatusFileSize
new show-errors-2974654-04.patch827 bytes

Change addStatus function to addError

jarodriguez’s picture

jarodriguez commented
Status: Active » Needs review
quietone’s picture

quietone commented
Status: Needs review » Needs work
Issue tags: +Needs screenshots

@jarodriguez, thank you. Can you add a screenshot of the change?

jarodriguez’s picture

jarodriguez commented

Hi!, I fixed the message color, But I do not have any migration ready.

Can you send me your migration to try?

jarodriguez’s picture

jarodriguez commented
Status: Needs work » Needs review
heddn’s picture

heddn
Primary language English
Location Illinois
commented
Issue tags: +Novice

Tagging novice for screenshots.

quietone’s picture

quietone commented

@jarodriguez, I don't recall what db I was using at the time. There may be more going on here than just an odd output. I attempted to force the error by breaking the trackernode migration and then migrating the D7 test fixture. The migration ran and reported that all migrations were successful so I didn't break it well enough.

So we need steps to reproduce.

quietone’s picture

quietone commented
Status: Needs review » Needs work
quietone’s picture

quietone commented

Good news, I just got this type of screen using the Drupal6 test fixture.

I uninstalled a bunch of modules before running the migration. The modules were node, comment, color, config_translation, content_translation, language, locale, rdf, automated_cron, big_pipe, breakpoint, contact, rdf, image, quickedit. I was just on a spree uninstalling, even modules that don't have migrations.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

vj’s picture

vj commented
StatusFileSize
new after_patch.png50.78 KB
new before_patch.png53.8 KB

Screenshots for the issue.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs work » Reviewed & tested by the community
Issue tags: -Needs screenshots

Screenshots have been provided and the patch is trivial, looks good to me.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Looks good to me to.

Committed and pushed 2bfba7fe68 to 8.7.x and 92757fdd4c to 8.6.x. Thanks!

  • alexpott committed 2bfba7f on 8.7.x 
    Issue #2974654 by jarodriguez, Vj, quietone: Migrate upgrade shows...

  • alexpott committed 92757fd on 8.6.x 
    Issue #2974654 by jarodriguez, Vj, quietone: Migrate upgrade shows...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.