Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
In focal_point.js
we have:
$(".focal-point", context).once('focal-point-hide-field').each(function() {
// Hide the focal_point form item. We do this with js so that a non-js
// user can still set the focal point values. Also, add functionality so
// that if the indicator is double clicked, the form item is displayed.
if (!$(this).hasClass('error')) {
$(this).closest('.form-item').hide();
}
});
The form-item
class, even if very common, is added by the classy theme, and sites may not be extending from that. We should add our own wrapper class and rely on that instead.
Proposed resolution
Add a custom class to the form element wrapper and change the javascript to rely on that class instead.
Remaining tasks
User interface changes
API changes
Data model changes
Comment | File | Size | Author |
---|---|---|---|
#2 | 2974169-2.patch | 1.1 KB | marcoscano |
Comments
Comment #2
marcoscanoComment #4
marcoscanoNot sure what's going on with the testbot.
Comment #5
BerdirLooks like a problem with nightwatch testing which is in 8.6 and contrib. I triggered a test with 8.5. I recommend setting the patch test branch to pre-release, then it sticks to 8.5 until 8.6 is out as a beta or release candidate.
Patch looks good to me.
Comment #6
BerdirComment #8
bleen CreditAttribution: bleen at NBCUniversal commentedThanks!