Problem/Motivation

In focal_point.js we have:

      $(".focal-point", context).once('focal-point-hide-field').each(function() {
        // Hide the focal_point form item. We do this with js so that a non-js
        // user can still set the focal point values. Also, add functionality so
        // that if the indicator is double clicked, the form item is displayed.
        if (!$(this).hasClass('error')) {
          $(this).closest('.form-item').hide();
        }
      });

The form-item class, even if very common, is added by the classy theme, and sites may not be extending from that. We should add our own wrapper class and rely on that instead.

Proposed resolution

Add a custom class to the form element wrapper and change the javascript to rely on that class instead.

Remaining tasks

User interface changes

API changes

Data model changes

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

marcoscano created an issue. See original summary.

marcoscano’s picture

Assigned: marcoscano » Unassigned
Status: Active » Needs review
FileSize
1.1 KB

Status: Needs review » Needs work

The last submitted patch, 2: 2974169-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

marcoscano’s picture

Status: Needs work » Needs review

Not sure what's going on with the testbot.

Berdir’s picture

Looks like a problem with nightwatch testing which is in 8.6 and contrib. I triggered a test with 8.5. I recommend setting the patch test branch to pre-release, then it sticks to 8.5 until 8.6 is out as a beta or release candidate.

Patch looks good to me.

Berdir’s picture

Status: Needs review » Reviewed & tested by the community

  • bleen committed 31c4493 on 8.x-1.x authored by marcoscano
    Issue #2974169 by marcoscano, Berdir: Do not rely on classes from classy...
bleen’s picture

Status: Reviewed & tested by the community » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.