Problem/Motivation

#2814055: Allow modules to react to replication events has now landed, but the events are being dispatched during replication when they should be dispatched before and after replication.

Proposed resolution

Update event dispatching

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#12 interdiff.txt3.4 KBjeqq
#12 2971926-12.patch13.31 KBjeqq
#11 2971926-11.patch12.95 KBl0ke
#11 interdiff-2971926-8-11.txt1.83 KBl0ke
#9 2971926-8.patch11.23 KBaxicdv
#8 interdiff-2971926-8.txt11.16 KBaxicdv
#6 2971926-6.patch6.07 KBtimmillwood
#4 2971926-4.patch6.09 KBtimmillwood

Comments

timmillwood created an issue. See original summary.

timmillwood credited phenaproxima.

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
commented
timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
commented
Status: Active » Needs review
StatusFileSize
new 2971926-4.patch6.09 KB

Initial patch

Status: Needs review » Needs work

The last submitted patch, 4: 2971926-4.patch, failed testing. View results

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
commented
Status: Needs work » Needs review
StatusFileSize
new 2971926-6.patch6.07 KB

Let's try that again.

jeqq’s picture

jeqq commented
Status: Needs review » Needs work

I think this needs testing. Maybe we can extend ReplicatorTest with tests that will cover the new events?

axicdv’s picture

axicdv commented
StatusFileSize
new interdiff-2971926-8.txt11.16 KB
axicdv’s picture

axicdv commented
StatusFileSize
new 2971926-8.patch11.23 KB
axicdv’s picture

axicdv commented
Status: Needs work » Needs review
l0ke’s picture

l0ke
Primary language English
Location Ukraine
commented
Assigned: timmillwood » Unassigned
StatusFileSize
new interdiff-2971926-8-11.txt1.83 KB
new 2971926-11.patch12.95 KB

ReplicatorTest extended with Prophecy to ensure events are dispatched properly.

jeqq’s picture

jeqq commented
StatusFileSize
new 2971926-12.patch13.31 KB
new interdiff.txt3.4 KB

The patch looks good. I've done just some minor refactoring.

jeqq’s picture

jeqq commented

.

  • jeqq committed 86704a3 on 8.x-1.x 
    Issue #2971926 by timmillwood, jeqq, axicdv, l0ke, phenaproxima: Better...
jeqq’s picture

jeqq commented
Status: Needs review » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.