While evaluating this module, I noticed it lacked a readme.
According to Drupal standards, modules should include a useful README.file.
https://www.drupal.org/docs/develop/documenting-your-project/module-docu....
Patch to follow, thanks!

CommentFileSizeAuthor
#2 textfield_counter-readme-fix-2971407-2.patch2.06 KBvolkswagenchick

Comments

volkswagenchick created an issue. See original summary.

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
Assigned: volkswagenchick » Unassigned
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new textfield_counter-readme-fix-2971407-2.patch2.06 KB

I have uploaded a patch that contains a readme file that conforms to Drupal documentation standards. Thanks for all the work you do!! This is a great module.

dani3lr0se’s picture

dani3lr0se commented
Status: Needs review » Reviewed & tested by the community

Patch applies cleanly and the info does seem helpful. It's always nice to have some useful info in READMEs. Other than that, it looks good. Grammar/Spelling, etc. are all good. Looks like it aligns with Drupal recommended standards as well. Thanks for the patch @volkswagenchick.

jaypan’s picture

jaypan
Location Victoria, BC
commented
Status: Reviewed & tested by the community » Fixed

Thanks for the patch. It's been committed.

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented

Thankyou for all the work you do!!
I am encouraging team mates to help out on Drupal.org, could you go back and give daniel_rose a credit for his RTBC?? He took the time to test and make sure the configs, link, etc were correct.
The box next to his name just gets ticked and he gets a credit! I see it as a way of incentive to help get involved it the community! It takes a village.

Cheers!

AmyJune - volkswagenchick

jaypan’s picture

jaypan
Location Victoria, BC
commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.