CommentFileSizeAuthor
#9 modules_terms_of_use.png10.01 KBakshay kashyap
#5 readme_2969455-2.patch1.49 KBkeshavv
#2 readme_2969455-1.patch2.95 KBkeshavv

Comments

keshav.k created an issue. See original summary.

keshavv’s picture

keshavv commented
StatusFileSize
new readme_2969455-1.patch2.95 KB

Please add readme.md file on 8x module and review.

keshavv’s picture

keshavv commented
Status: Needs work » Needs review
keshavv’s picture

keshavv commented
StatusFileSize
new readme_2969455-2.patch1.49 KB

Re-rolling patch according to drupal 8 standards - https://www.drupal.org/docs/develop/documenting-your-project/readme-temp...

keshavv’s picture

keshavv commented
StatusFileSize
new readme_2969455-2.patch1.49 KB

Re-rolling patch according to drupal 8 standards - https://www.drupal.org/docs/develop/documenting-your-project/readme-temp...

keshavv’s picture

keshavv commented
Assigned: keshavv » Unassigned
amit.drupal’s picture

amit.drupal commented

@keshav.k Patch is looking fine, Its ready for RTBC.

amit.drupal’s picture

amit.drupal commented
Status: Needs review » Reviewed & tested by the community
akshay kashyap’s picture

akshay kashyap commented
Status: Reviewed & tested by the community » Needs work
StatusFileSize
new modules_terms_of_use.png10.01 KB

@keshav.k

I have review the patch, apply successfully and working fine. but give one warning message please check it. i have attached the screenshot.

akshay kashyap’s picture

akshay kashyap commented
Status: Needs work » Needs review
keshavv’s picture

keshavv commented
Status: Needs review » Reviewed & tested by the community
ivnish’s picture

ivnish
he/him
commented

Thanks!

  • ivnish committed 144c37a on 8.x-2.x 
    Issue #2969455 by keshav.k, Akshay kashyap, amit.drupal, ivnish: README....
ivnish’s picture

ivnish
he/him
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.