Test failing in HEAD because 'register' is missing from the mocked class.

CommentFileSizeAuthor
#2 2969420-2.patch735 bytesjoelpittet

Comments

joelpittet created an issue. See original summary.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Active » Needs review
StatusFileSize
new 2969420-2.patch735 bytes

This should make the tests pass in HEAD

idebr’s picture

idebr commented
Status: Needs review » Reviewed & tested by the community

@joelpittet Thanks for taking the time to fix the tests!

The patch in #2 fixes the automated tests

@dakku Can you enable a daily test on the 'Automated testing' tab, so failures in HEAD become visible on the tab 'Automated testing' on the project page? This would prevent confusion with contributors when posting patches, for example #2962714: Simplestest to PHPUnit Functional Tests

dakku’s picture

dakku commented

@joelpittet thanks for the patch and reaching out! I will get this committed later today.
@idebr - test schedule is changed to daily :)

  • dakku committed cf3ca08 on 8.x-3.x authored by joelpittet 
    Issue #2969420 by joelpittet: Tests failing in HEAD due to missing...
dakku’s picture

dakku commented
Status: Reviewed & tested by the community » Fixed
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

Thanks @dakku!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.