CommentFileSizeAuthor
#9 remove_t_function_2968674_9.patch4.66 KBbunty badgujar
#3 Screen Shot 2018-05-02 at 12.50.22 PM.png55.75 KBakash.addweb
#2 remove_t_function_2968674_1.patch4.59 KBchanderbhushan

Comments

chanderbhushan created an issue. See original summary.

chanderbhushan’s picture

chanderbhushan commented
Status: Active » Needs review
StatusFileSize
new remove_t_function_2968674_1.patch4.59 KB

added patch for same.

akash.addweb’s picture

akash.addweb commented
Status: Needs review » Needs work
StatusFileSize
new Screen Shot 2018-05-02 at 12.50.22 PM.png55.75 KB

@chanderbhushan, Thanks for the patch, but when I apply your patch to check then it shows me the hunk errors that attached in the screenshot, Can you please do the needful.

akash.addweb’s picture

akash.addweb commented
Status: Needs work » Reviewed & tested by the community
akash.addweb’s picture

akash.addweb commented
Status: Reviewed & tested by the community » Needs work
chanderbhushan’s picture

chanderbhushan commented
Status: Needs work » Needs review

Hi please use git apply -v > patch file

vandna b’s picture

vandna b commented

I tested #2 patch . Working fine .

vandna b’s picture

vandna b commented
Status: Needs review » Reviewed & tested by the community
bunty badgujar’s picture

bunty badgujar commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new remove_t_function_2968674_9.patch4.66 KB

Re-rolling patch #2 with small bug fix.

  • Bunty Badgujar authored 565316f on 8.x-1.x 
    Issue #2968674 by chanderbhushan, Bunty Badgujar, Ronak.addweb, vandna b...
bunty badgujar’s picture

bunty badgujar commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

vandna b’s picture

vandna b commented