While evaluating this module, we noticed the README lacked some useful links and configs as per d.o documentation standards.
Also some of the information (VotingAPI requires Drupal 4.7 or later.) is antiquated.

Patch to follow, thanks!!

CommentFileSizeAuthor
#7 interdiff_2-4.txt1.25 KBpifagor
#5 votingapi-fix-readme-2966883-4.patch3.53 KBpifagor
#4 eck-Add-support-to-eck-for-auto_entitylabel-2905426-12-D8.patch1.06 KBpifagor
#2 votingapi-fix-readme-2966883-2.patch3.44 KBvolkswagenchick

Comments

volkswagenchick created an issue. See original summary.

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
Assigned: volkswagenchick » Unassigned
Status: Active » Needs review
StatusFileSize
new votingapi-fix-readme-2966883-2.patch3.44 KB

I uploaded a patch that adds some useful configs and information to the README file. I took the time to align it to d.o documnetation standards as well.

Thanks for this useful module!!

dani3lr0se’s picture

dani3lr0se commented
Status: Needs review » Reviewed & tested by the community

Patch applies cleanly in my local site. Readme format, grammar, and readability look good. The readme makes sense and provides helpful info. Thanks for the patch @volkswagenchick.

pifagor’s picture

pifagor
Location 🇺🇦 Rivne
commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new eck-Add-support-to-eck-for-auto_entitylabel-2905426-12-D8.patch1.06 KB

Thank you very much for your contribution to the module. I've slightly expanded the description. Please check the information. Of course, when will commit, I will add credit to everyone who has been making efforts to the improvement of the module.

pifagor’s picture

pifagor
Location 🇺🇦 Rivne
commented
StatusFileSize
new votingapi-fix-readme-2966883-4.patch3.53 KB

Sorry, the wrong patch :( was deleted.

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented

Hi @pifagor I can't seem to find any difference's between patch 2 and 5 - maybe an interdiff would help??

pifagor’s picture

pifagor
Location 🇺🇦 Rivne
commented
StatusFileSize
new interdiff_2-4.txt1.25 KB

Hi @volkswagenchick
Of course, here is a file. There are only refinement changes

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
Status: Needs review » Reviewed & tested by the community

Ah - very good. Marking RTBC.

voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
commented

+1 for RTBC

alex_optim’s picture

alex_optim
Location Tallinn
commented

+1

  • pifagor committed 5d72baf on 8.x-3.x 
    Issue #2966883 by pifagor, volkswagenchick, alex_optim, daniel_rose,...
pifagor’s picture

pifagor
Location 🇺🇦 Rivne
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.