Closed (fixed)
Project:
Node Manager
Version:
8.x-1.0-alpha1
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
27 Apr 2018 at 10:34 UTC
Updated:
25 May 2018 at 12:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
lomasr commentedPatch added. My initial review about the module:
Comment #3
lomasr commentedComment #4
akshay kashyap commented#2 I have review the patch, apply successfully and working fine for me.
Comment #5
riddhi.addweb commented@lomasr, Thanks for the patch, but it is not as per the standards mentioned in Readme template Can you please do the needful with the use of https://www.drupal.org/docs/develop/documenting-your-project/readme-temp....
Comment #6
bunty badgujar commentedHi @lomasr,
Module is implemented in such a way that if you don't need to enable module for some content types then don't enable custom field in that content types in manage form. Date field is mandatory to have value from alpha2 release because new update allow you to send email to author of node. So, i don't think we need different setting for enabling module for specific content types.
Alternative :- you can delete the fields for content type you don't need this functionality.
Comment #7
priya.chat commentedHi, I am adding a new patch with required changes. Please review it.
Comment #8
vandna b commentedRe-rolling patch with more information.
Comment #9
Neetika K commented@priya.chat Patch is applied successfully.
Issue: But the first two lines are appearing empty in File.The Introduction should start from first line.
Expected: According to Drupal Standards the first two lines should not be empty.
Comment #10
Neetika K commented@vandna b : Patch error appeared
Comment #11
volkswagenchickGood day - I was evaluating this module yesterday and too found that the readme lacked some useful configs and links. I saw you posted this issue and am uploading the patch a created yesterday.
The patch includes a README that aligns to d.o documentation standards.
Comment #12
amit.drupal commentedPatch #11 is working fine, Modified patch.
Comment #13
volkswagenchickGood catch. I must have missed that section during copy and paste.
Marking RTBC.
Comment #15
bunty badgujar commented