Your README.md does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .

The INTRODUCTION section is missing.
The REQUIREMENTS section is missing.
The INSTALLATION section is missing.
The CONFIGURATION section is missing.

Comments

pvsureshmca created an issue. See original summary.

lomasr’s picture

StatusFileSize
new817 bytes

Patch added. My initial review about the module:

  1. Need to mention to enable custom fields created by the module from admin/structure/types
  2. Custom fields are being added in all the content type. Need have a another setting for selection of content types.
lomasr’s picture

Status: Active » Needs review
akshay kashyap’s picture

#2 I have review the patch, apply successfully and working fine for me.

riddhi.addweb’s picture

Status: Needs review » Needs work

@lomasr, Thanks for the patch, but it is not as per the standards mentioned in Readme template Can you please do the needful with the use of https://www.drupal.org/docs/develop/documenting-your-project/readme-temp....

bunty badgujar’s picture

Hi @lomasr,

  • Custom fields are being added in all the content type. Need have a another setting for selection of content types.

    Module is implemented in such a way that if you don't need to enable module for some content types then don't enable custom field in that content types in manage form. Date field is mandatory to have value from alpha2 release because new update allow you to send email to author of node. So, i don't think we need different setting for enabling module for specific content types.

    Alternative :- you can delete the fields for content type you don't need this functionality.

priya.chat’s picture

Status: Needs work » Needs review
StatusFileSize
new1.43 KB

Hi, I am adding a new patch with required changes. Please review it.

vandna b’s picture

StatusFileSize
new1.69 KB

Re-rolling patch with more information.

Neetika K’s picture

Status: Needs review » Needs work
StatusFileSize
new34.44 KB

@priya.chat Patch is applied successfully.
Issue: But the first two lines are appearing empty in File.The Introduction should start from first line.

Expected: According to Drupal Standards the first two lines should not be empty.

Neetika K’s picture

StatusFileSize
new54.2 KB

@vandna b : Patch error appeared

volkswagenchick’s picture

Status: Needs work » Needs review
StatusFileSize
new2.5 KB

Good day - I was evaluating this module yesterday and too found that the readme lacked some useful configs and links. I saw you posted this issue and am uploading the patch a created yesterday.
The patch includes a README that aligns to d.o documentation standards.

amit.drupal’s picture

StatusFileSize
new2.62 KB
new285 bytes

Patch #11 is working fine, Modified patch.

volkswagenchick’s picture

Status: Needs review » Reviewed & tested by the community

Good catch. I must have missed that section during copy and paste.
Marking RTBC.

  • amit.drupal authored bfca413 on 8.x-1.x
    Issue #2966764 by amit.drupal, volkswagenchick, lomasr, priya.chat,...
bunty badgujar’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.