CommentFileSizeAuthor
#6 smooth_mouse_scrolling-d8-2966676-6.patch2.32 KBchishah92
#3 smooth_mouse_scrolling-d8-2966676-#3.patch2.65 KBakash.addweb
#2 smooth_mouse_scrolling-d8-2966676-#2.patch1.67 KBMaheshwaran.j

Comments

Maheshwaran.j created an issue. See original summary.

Maheshwaran.j’s picture

Maheshwaran.j commented
Status: Active » Needs review
StatusFileSize
new smooth_mouse_scrolling-d8-2966676-#2.patch1.67 KB

Kindly review the patch.

akash.addweb’s picture

akash.addweb commented
StatusFileSize
new smooth_mouse_scrolling-d8-2966676-#3.patch2.65 KB

@Maheshwaran.j, Attached the patch for the missed changes that for the 'scroll'.

vandna b’s picture

vandna b commented
Status: Needs review » Needs work

#3
When I applied your patch its not working for me

vandna b’s picture

vandna b commented
chishah92’s picture

chishah92 commented
StatusFileSize
new smooth_mouse_scrolling-d8-2966676-6.patch2.32 KB

please review the new patch according to the actual patch naming convention.

chishah92’s picture

chishah92 commented
Status: Needs work » Needs review
praveenneelu’s picture

praveenneelu commented
Status: Needs review » Needs work

Hi @chishah92,
A part of this issue was already committed in the dev version.

Check here.
Patch Link: https://www.drupal.org/files/issues/2018-05-07/callback_name_change-2964...

Related Issue: https://www.drupal.org/project/smooth_mouse_scrolling/issues/2964860.

Kindly Update this issue.

siva_drupal’s picture

siva_drupal commented
Assigned: Unassigned » siva_drupal
Issue tags: -

Sorry the previous patch is not applied properly. We will process it and update the same.

  • chishah92 authored 6c20894 on 8.x-1.x 
    Issue #2966676 by Maheshwaran.j, chishah92, akash.addweb, siva_drupal:...
siva_drupal’s picture

siva_drupal commented
Status: Needs work » Fixed

Changes are committed into dev version.

siva_drupal’s picture

siva_drupal commented
Assigned: siva_drupal » Unassigned

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.