Problem/Motivation
FILE: ...areviewsh/pareview_temp/beautytips_manager/beautytips_manager.module
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
305 | WARNING | Unused variable $id.
--------------------------------------------------------------------------
FILE: ...or/drupal/pareviewsh/pareview_temp/src/Form/BeautytipsConfigForm.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 10 WARNINGS AFFECTING 9 LINES
--------------------------------------------------------------------------
31 | WARNING | \Drupal calls should be avoided in classes, use
| | dependency injection instead
93 | WARNING | t() calls should be avoided in classes, use dependency
| | injection and $this->t() instead
121 | WARNING | t() calls should be avoided in classes, use dependency
| | injection and $this->t() instead
121 | WARNING | t() calls should be avoided in classes, use dependency
| | injection and $this->t() instead
135 | WARNING | t() calls should be avoided in classes, use dependency
| | injection and $this->t() instead
151 | WARNING | \Drupal calls should be avoided in classes, use
| | dependency injection instead
169 | WARNING | t() calls should be avoided in classes, use dependency
| | injection and $this->t() instead
182 | WARNING | t() calls should be avoided in classes, use dependency
| | injection and $this->t() instead
192 | WARNING | \Drupal calls should be avoided in classes, use
| | dependency injection instead
254 | WARNING | \Drupal calls should be avoided in classes, use
| | dependency injection instead
--------------------------------------------------------------------------
FILE: ...r/drupal/pareviewsh/pareview_temp/beautytips_ui/beautytips_ui.module
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------
12 | WARNING | Unused variable $args.
43 | WARNING | Unused variable $args.
109 | WARNING | Unused variable $file.
--------------------------------------------------------------------------
FILE: ...drupal/pareviewsh/pareview_temp/beautytips_ui/beautytips_ui.info.yml
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
6 | WARNING | All dependencies must be prefixed with the project name,
| | for example "drupal:"
--------------------------------------------------------------------------
FILE: ...te1101/web/vendor/drupal/pareviewsh/pareview_temp/beautytips.install
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
20 | WARNING | Unused variable $type.
--------------------------------------------------------------------------
https://pareview.sh/pareview/https-git.drupal.org-project-beautytips.git
Proposed resolution
Fix all coding standard issues.
Remaining tasks
User interface changes
API changes
Data model changes
Comments
Comment #2
arunkumarkComment #3
priya.chat commentedHi, I am trying to solve the available defects as directed above also using the 8.x-1.0-alpha2 version of this module. Adding the patch please review it.
Comment #4
msankhala commentedThis patch is only modifying componser.json file. This patch is not fixing any of the coding standards as reported in issue description.
Comment #5
vinod_kc commentedComment #6
vinod_kc commentedThere are lots of coding standard issues in this module. Attaching a patch with partial fix.
Comment #7
pifagorComment #8
vinod_kc commentedComment #9
akshay kashyap commented@vinod_kc :-
README.tx file does not follow best practices (headings need to be uppercase).
See https://www.drupal.org/docs/develop/documenting-your-project/readme-temp...
The INTRODUCTION section is missing.
The REQUIREMENTS section is missing.
The INSTALLATION section is missing.
The CONFIGURATION section is missing
Comment #10
akshay kashyap commentedComment #11
thallesFollows a patch with partial fix.
Comment #12
thallesFollows a patch with partial fix.
Comment #13
alex_optimThe patch is not applied. Need to re-create.
Comment #14
alex_optimComment #15
thallesFollow the patch!
Comment #16
thallesComment #17
alex_optimLooks good.
Comment #18
pifagorComment #20
pifagor