Problem/Motivation

FILE: ...areviewsh/pareview_temp/beautytips_manager/beautytips_manager.module
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
 305 | WARNING | Unused variable $id.
--------------------------------------------------------------------------


FILE: ...or/drupal/pareviewsh/pareview_temp/src/Form/BeautytipsConfigForm.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 10 WARNINGS AFFECTING 9 LINES
--------------------------------------------------------------------------
  31 | WARNING | \Drupal calls should be avoided in classes, use
     |         | dependency injection instead
  93 | WARNING | t() calls should be avoided in classes, use dependency
     |         | injection and $this->t() instead
 121 | WARNING | t() calls should be avoided in classes, use dependency
     |         | injection and $this->t() instead
 121 | WARNING | t() calls should be avoided in classes, use dependency
     |         | injection and $this->t() instead
 135 | WARNING | t() calls should be avoided in classes, use dependency
     |         | injection and $this->t() instead
 151 | WARNING | \Drupal calls should be avoided in classes, use
     |         | dependency injection instead
 169 | WARNING | t() calls should be avoided in classes, use dependency
     |         | injection and $this->t() instead
 182 | WARNING | t() calls should be avoided in classes, use dependency
     |         | injection and $this->t() instead
 192 | WARNING | \Drupal calls should be avoided in classes, use
     |         | dependency injection instead
 254 | WARNING | \Drupal calls should be avoided in classes, use
     |         | dependency injection instead
--------------------------------------------------------------------------


FILE: ...r/drupal/pareviewsh/pareview_temp/beautytips_ui/beautytips_ui.module
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------
  12 | WARNING | Unused variable $args.
  43 | WARNING | Unused variable $args.
 109 | WARNING | Unused variable $file.
--------------------------------------------------------------------------


FILE: ...drupal/pareviewsh/pareview_temp/beautytips_ui/beautytips_ui.info.yml
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
 6 | WARNING | All dependencies must be prefixed with the project name,
   |         | for example "drupal:"
--------------------------------------------------------------------------


FILE: ...te1101/web/vendor/drupal/pareviewsh/pareview_temp/beautytips.install
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
 20 | WARNING | Unused variable $type.
--------------------------------------------------------------------------

https://pareview.sh/pareview/https-git.drupal.org-project-beautytips.git

Proposed resolution

Fix all coding standard issues.

Remaining tasks

User interface changes

API changes

Data model changes

Comments

arunkumark created an issue. See original summary.

arunkumark’s picture

Issue summary: View changes
priya.chat’s picture

Status: Active » Needs review
StatusFileSize
new4.49 KB

Hi, I am trying to solve the available defects as directed above also using the 8.x-1.0-alpha2 version of this module. Adding the patch please review it.

msankhala’s picture

Status: Needs review » Needs work

This patch is only modifying componser.json file. This patch is not fixing any of the coding standards as reported in issue description.

vinod_kc’s picture

Assigned: Unassigned » vinod_kc
vinod_kc’s picture

StatusFileSize
new57.01 KB

There are lots of coding standard issues in this module. Attaching a patch with partial fix.

pifagor’s picture

Status: Needs work » Needs review
vinod_kc’s picture

Assigned: vinod_kc » Unassigned
akshay kashyap’s picture

@vinod_kc :-

README.tx file does not follow best practices (headings need to be uppercase).
See https://www.drupal.org/docs/develop/documenting-your-project/readme-temp...

The INTRODUCTION section is missing.
The REQUIREMENTS section is missing.
The INSTALLATION section is missing.
The CONFIGURATION section is missing

akshay kashyap’s picture

Status: Needs review » Needs work
thalles’s picture

StatusFileSize
new52.66 KB

Follows a patch with partial fix.

thalles’s picture

Status: Needs work » Needs review
StatusFileSize
new52.61 KB

Follows a patch with partial fix.

alex_optim’s picture

The patch is not applied. Need to re-create.

alex_optim’s picture

Status: Needs review » Needs work
thalles’s picture

StatusFileSize
new12.15 KB

Follow the patch!

thalles’s picture

Status: Needs work » Needs review
alex_optim’s picture

Looks good.

pifagor’s picture

  • pifagor committed cdce49b on 8.x-1.x authored by thalles
    Issue #2966280 by thalles, vinod_kc, priya.chat, alex_optim, arunkumark...
pifagor’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.