CommentFileSizeAuthor
#12 2966266-12.patch1.45 KBbrahmjeet789
#9 interdiff.txt1.02 KBamit.drupal
#9 2966266-8.patch1.3 KBamit.drupal
#4 2966266-4.patch1.3 KBbhanuprakashnani
#2 README.txt778 bytessarguna raj m

Comments

opdavies created an issue. See original summary.

sarguna raj m’s picture

sarguna raj m commented
Status: Active » Needs review
StatusFileSize
new README.txt778 bytes

Hi opdavies,

I have attachment sample Readme txt.

Refer Readme template URL: https://www.drupal.org/docs/develop/documenting-your-project/readme-temp...

Thanks.

riddhi.addweb’s picture

riddhi.addweb commented
Status: Needs review » Needs work

@sarguna raj M, Can you please make this patch file as per the standard format of readme.

bhanuprakashnani’s picture

bhanuprakashnani commented
Assigned: Unassigned » bhanuprakashnani
Status: Needs work » Needs review
StatusFileSize
new 2966266-4.patch1.3 KB

Changed the README file according to the Drupal Readme Standards. Please review and mention if any more changes are to be made. Thank you.

bhanuprakashnani’s picture

bhanuprakashnani commented

Can i get a review please??

vandna b’s picture

vandna b commented

#4 I have tested your patch it fulfills the requirement README file according to the Drupal Readme Standards

bhanuprakashnani’s picture

bhanuprakashnani commented
Status: Needs review » Reviewed & tested by the community
opdavies’s picture

opdavies
He/him
Primary language English
Location Wales
commented
Status: Reviewed & tested by the community » Needs work

This seems to be in the wrong format. Looking at the links, It's a markdown file rather than a text file.

amit.drupal’s picture

amit.drupal commented
StatusFileSize
new 2966266-8.patch1.3 KB
new interdiff.txt1.02 KB

Updated Patch.

amit.drupal’s picture

amit.drupal commented
Status: Needs work » Needs review
msankhala’s picture

msankhala commented
Status: Needs review » Needs work 
+++ b/README.txt
@@ -0,0 +1,59 @@
+ * Install as you would normally install a contributed Drupal module. ¶

Trailing white space.

brahmjeet789’s picture

brahmjeet789 commented
Status: Needs work » Needs review
StatusFileSize
new 2966266-12.patch1.45 KB

i have removed trailing white space in #8 patch ,please review my patch.

lomasr’s picture

lomasr commented

@brahmjeet789 Please add INTRODUCTION.

lomasr’s picture

lomasr commented
Status: Needs review » Needs work
brahmjeet789’s picture

brahmjeet789 commented

@lomasr i already added introduction ,please recheck it.

lomasr’s picture

lomasr commented

@brahmjeet789 I can see the heading but nothing under it. Not sure from the readme.txt what is the use of this module. Nothing on the project page either https://www.drupal.org/project/system_user

msankhala’s picture

msankhala commented

Yes, project page does not has any description. There is an issue for that #2975067: Add description on project page
This module creates a new user account named "[site:name] system user " without any email address on installation which has authenticated user role.

Drupal gives the ability to create the new user account. I am not sure in what cases this module can be helpful.

msankhala’s picture

msankhala commented

@opdavies Can you please add more description on project page itself which can be used as a part of README file.?