Closed (fixed)
Project:
Entity Sanitizer
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
25 Apr 2018 at 15:13 UTC
Updated:
17 Oct 2019 at 11:49 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
kingdutchChanged issue title to reflect the purpose of this issue.
Comment #3
navneet0693 commentedComment #4
kingdutchIn entity_sanitizer_drush_command
Line 76, you've removed the examples on how to do quick debugging but you've not removed the debug comment that's not actually a TODO ^^'. Please either remove all three comment lines here or leave the example intact.
Please create a ticket that describes what you dislike about the logic and create an issue in the issue queue that can be referenced.
In example.whitelist.yml
Line 211, you're only skipping
userinto it's entirety soDon't sanitize user entities.Line 214:
Don't sanitize article bundle of node entities.Line 216, you're working with the page bundle here:
+ # Don't sanitize titles for the node page bundle.Line 220, this change is incorrect, please revert it.
Comment #5
navneet0693 commentedThanks @Kingdutch for review. I have added an improved patch. I will also add a follow-up issue once the patch is in.
Comment #6
kingdutchHi Navneet,
Please create the follow-up ahead of time so it can be added to the // TODO statement. Otherwise we'll have a TODO statement in 6 months and don't know what actually needs to happen.
Additionally, when making fixes to a patch it's good practice to create an interdiff which makes reviewing the newest changes easier :) See https://www.drupal.org/documentation/git/interdiff for more info.
~ Alexander
Comment #7
navneet0693 commentedThanks @Kingdutch, I have added the follow-up issue link in todo and also have improved coding standards.
Comment #8
navneet0693 commented:facepalm:
for uploading an empty patch. I need more concentration:-P
Comment #10
kingdutchCommitted and tagged in 1.0-alpha10, thanks!