It needs to either be documented that shim mode has to be turned on or better yet block--floating-social-icons.html.twig should reference the non-shim versions.

CommentFileSizeAuthor
#7 floating_social_icons-d8-2965811-#7.patch3.45 KBMaheshwaran.j

Comments

Christopher Riley created an issue. See original summary.

Maheshwaran.j’s picture

Maheshwaran.j commented

Can you be more elaborative about this issue.? Is this regarding the font awesome span tag in twig changes to SVG tag?

Christopher Riley’s picture

Christopher Riley commented

For example at the moment you have in templates/block--floating-social-icons.html.twig the facebook icon defined as which is fine for version 4 or if you have the shim active. However according to https://fontawesome.com/icons?d=gallery&q=facebook it should be facebook-f or facebook or facebook-square, etc.

Its not really a big deal and easily corrected if someone does a custom template however I was thiniking it miught be better to address it now or at least put a comment in the readme to enable the shim mode within the fontawesome module.

Maheshwaran.j’s picture

Maheshwaran.j commented

So if I'm correct instead of using fa fa-facebook we can go for facebook-f or facebook or facebook-square, etc. As font-awesome gets upgraded the fa will be deprecated right?.

Christopher Riley’s picture

Christopher Riley commented

That is correct the way that I read things. Since we have the ability to have multiple of the same type of icons maybe we should do something similar to what Fontawesome Menu Icons does and allow the user to choose which icon to use via Font Awesome Icon Picker

Maheshwaran.j’s picture

Maheshwaran.j commented

I will have to look into possiblities or feasibility. Does Drupal Font awesome support these facebook-f or facebook or facebook-square Should I have to provide option at admin end. I would be glad if you provide a patch for it.

Maheshwaran.j’s picture

Maheshwaran.j commented
Status: Active » Needs review
StatusFileSize
new floating_social_icons-d8-2965811-#7.patch3.45 KB

@Christopher Riley

I have created a patch based on this issue, please review this. if this fine we can commit the patch and update on readme file on using version 5 of font awesome.

Christopher Riley’s picture

Christopher Riley commented

Thank you very much the patch seems to do the trick I would like to see it get committed.

Maheshwaran.j’s picture

Maheshwaran.j commented

@Christopher Riley

Ok

Maheshwaran.j’s picture

Maheshwaran.j commented

Can you review this patch? and change status to RTBC

Maheshwaran.j’s picture

Maheshwaran.j commented

I am committing this patch anyway. I don't find any major issues. This will come in next release.

  • Maheshwaran.j committed 48f8512 on 8.x-1.x 
    Issue #2965811 by Maheshwaran.j: Get rid of needing shim mode
Maheshwaran.j’s picture

Maheshwaran.j commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.