While evaluating the module we noticed that the hook_help could use some more helpful info to provide to users. Patch to follow. :)

CommentFileSizeAuthor
#10 patch 7 after.png20.94 KBvolkswagenchick
#7 voting-api-hook_help-2965760-7.patch1.2 KBpifagor
#6 patch 5 after.png12.95 KBvolkswagenchick
#5 voting-api-hook_help-2965760-5.patch1.2 KBpifagor
#4 voting API help page - after.png18.44 KBvolkswagenchick
#4 voting API help page - before.png20.01 KBvolkswagenchick
#2 voting-api-hook_help-2965760-2.patch733 bytesdani3lr0se

Comments

daniel_rose created an issue. See original summary.

dani3lr0se’s picture

dani3lr0se commented
StatusFileSize
new voting-api-hook_help-2965760-2.patch733 bytes

Here is a patch that adds a little bit of helpful info into the hook_help. Thanks for your work on this module. :)

dani3lr0se’s picture

dani3lr0se commented
Assigned: dani3lr0se » Unassigned
Status: Active » Needs review
volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new voting API help page - before.png20.01 KB
new voting API help page - after.png18.44 KB

Patch applied locally with no issues. The help text on the help page is better and links to the project page for more info.

Screenshots attached.

pifagor’s picture

pifagor
Location 🇺🇦 Rivne
commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new voting-api-hook_help-2965760-5.patch1.2 KB

Thank you for your work. I changed the patch. Please try again, test.

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
Status: Needs review » Needs work
StatusFileSize
new patch 5 after.png12.95 KB

Patch in comment 5 applied locally. Screenshot attached. The project page link does not work. Marking needs work.

pifagor’s picture

pifagor
Location 🇺🇦 Rivne
commented
Status: Needs work » Needs review
StatusFileSize
new voting-api-hook_help-2965760-7.patch1.2 KB

I'm sorry I could not tested the patch. Now everything has to work.

pifagor’s picture

pifagor
Location 🇺🇦 Rivne
commented
nkoporec’s picture

nkoporec
Primary language English
Location Slovenia
commented
Status: Needs review » Reviewed & tested by the community

Tested your latest patch and it works as expected.Marking this as RTBC.

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
Issue summary: View changes
StatusFileSize
new patch 7 after.png20.94 KB

I too, tested the patch in comment #7 and it indeed applied. Links all work as expected. I wanted to attach a screenshot for posterity. I agreed with the RTBC.

Thanks @daniel_rose for the initial patch and @pifagor for the adjustment.

  • pifagor committed aafc914 on 8.x-3.x 
    Issue #2965760 by pifagor, daniel_rose, volkswagenchick: Missing info in...
pifagor’s picture

pifagor
Location 🇺🇦 Rivne
commented
Status: Reviewed & tested by the community » Fixed
pifagor’s picture

pifagor
Location 🇺🇦 Rivne
commented

Thank you all for the good work!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.