Hi,

The README.md does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737

CommentFileSizeAuthor
#6 readMe-simple_popup_views-2964944-5.patch980 bytessivaprasadc
#5 interdiff-2964944-2-5.txt342 bytessivaprasadc
#4 47444.png106.87 KBriddhi.addweb
#2 readMe-simple_popup_views-2964944-2.patch983 bytessivaprasadc

Comments

Sivaprasad C created an issue. See original summary.

sivaprasadc’s picture

sivaprasadc commented
Assigned: sivaprasadc » Unassigned
Status: Active » Needs review
StatusFileSize
new readMe-simple_popup_views-2964944-2.patch983 bytes

Hi,

I have created a Patch based on the sample of README.md file standards. Please review it.

riddhi.addweb’s picture

riddhi.addweb commented

@Sivaprasad C, Thanks for providing README file, I have couple issues, which I mentioned below:
1) Remove extra line above the "Installation" section, Currently, it shows 3 lines.
2) Bulleted lists indented 1 space.

PFA.

Thanks!.

riddhi.addweb’s picture

riddhi.addweb commented
StatusFileSize
new 47444.png106.87 KB
sivaprasadc’s picture

sivaprasadc commented
StatusFileSize
new interdiff-2964944-2-5.txt342 bytes

@riddhi.addweb, Thanks for reviewing, Your suggestion make sense.

As per suggestion i have created the Patch file. PFA.

sivaprasadc’s picture

sivaprasadc commented
StatusFileSize
new readMe-simple_popup_views-2964944-5.patch980 bytes

  • Sivaprasad C authored c337f97 on 8.x-1.x 
    Issue #2964944 by Sivaprasad C, riddhi.addweb: No valid data in Read me...
ameer khan’s picture

ameer khan commented

Patches applied. Thank you.

ameer khan’s picture

ameer khan commented
ameer khan’s picture

ameer khan commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.