I've made some small fix to the code to prevent unwanted notices being produced and added the initial integration test with module Flags

CommentFileSizeAuthor
#2 fix_error_for_enable_flags_option-1.patch3.61 KBvalentine94
fix_error_for_enable_flags_option.patch546 bytesvalentine94

Comments

Valentine94 created an issue. See original summary.

valentine94’s picture

valentine94
Location Kyiv, Ukraine
commented
StatusFileSize
new fix_error_for_enable_flags_option-1.patch3.61 KB

Sorry, forgot the tests :)

Status: Needs review » Needs work

The last submitted patch, 2: fix_error_for_enable_flags_option-1.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

valentine94’s picture

valentine94
Location Kyiv, Ukraine
commented

Looks like tests couldn't install contrib modules if we just specifying them in the tests. It is working for Select2 Bef sub-module, e.g. this module has a dependency to the Better Exposed Filters module, that's why it get's correctly installed. I'm leaving a patch with a fix only here and will take a look for any possible workarounds for installing our soft-dependencies to make some integration tests

valentine94’s picture

valentine94
Location Kyiv, Ukraine
commented
Assigned: Unassigned » valentine94
valentine94’s picture

valentine94
Location Kyiv, Ukraine
commented
Assigned: valentine94 » Unassigned
Status: Needs work » Needs review

OK, looks like Drupal tests(Javascript Functional tests) not allows to install additional module that aren't under a dependencies list within a test. It is allowed only for Kernel tests(integration tests), but Kernel tests are the back-end tests, e.g. it's can be used to test some back-end functionalities, calculations etc. but not the front-end behaviors. Since this module is front-end tool firstly - we have to test it using front-end based testing

matsbla’s picture

matsbla commented
Title: Small fix to the flags integration code + tests » Remove undefined index when flags module is enabled

Okay lest just fix the undefined variable for now and look into tests for it later!

  • matsbla committed 9315f8e on 8.x-1.x authored by Valentine94 
    Issue #2963474 by Valentine94: Remove undefined index when flags module...
matsbla’s picture

matsbla commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.