Problem/Motivation

This is a follow #2562845: Validate file path on Credential form up to correct the source path field labels on the Credential Form. In #74 phenaproxima suggested changing 'Private file' to 'Private files. Is that what should be done?

Noting that on admin/config/media/file-system the singular, 'file' is used as in 'Public file' and 'Private file'. Yes, the context is different but maybe use that form as a guide?

Drupal 7 version before:

Proposed resolution

Drupal 7 version with new title.

No change to the Drupal6 version.

Remaining tasks

Decide on the text
Write a patch
Review
Commit

User interface changes

Yes, the label for the 3 source path fields on the Credential form.

CommentFileSizeAuthor
#4 interdiff.txt783 bytesquietone
#4 2962594-4.patch1.56 KBquietone
#2 2962594-2.patch810 bytesquietone
#2 Selection_016.png7.08 KBquietone
#2 Selection_017.png3.01 KBquietone
#2 before.png7.08 KBquietone

Comments

quietone created an issue. See original summary.

quietone’s picture

quietone commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new before.png7.08 KB
new Selection_017.png3.01 KB
new Selection_016.png7.08 KB
new 2962594-2.patch810 bytes

Changed the title field from 'Private file' to 'Private files' for the d7 version of the form. Attached is a before image and an after image of both the d6 and d7 version of the credential form. There is no change to the Drupal 6 version, it is just included for comparison.

Status: Needs review » Needs work

The last submitted patch, 2: 2962594-2.patch, failed testing. View results

quietone’s picture

quietone commented
Status: Needs work » Needs review
StatusFileSize
new 2962594-4.patch1.56 KB
new interdiff.txt783 bytes

Silly me didn't update the test as well.

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Needs review » Reviewed & tested by the community

Fairly simple text change that aligns with the actual name of things. LGTM.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed c023840 and pushed to 8.6.x. Thanks!

+++ b/core/modules/migrate_drupal_ui/src/Form/CredentialForm.php
@@ -188,7 +188,7 @@ public function buildForm(array $form, FormStateInterface $form_state) {
-      '#title' => $this->t('Private file directory'),
+      '#title' => $this->t('Private files directory'),

This is really good because then there is one less translation. We have 'title' => t('Private files directory'), in system_requirements().

  • alexpott committed c023840 on 8.6.x 
    Issue #2962594 by quietone: Make source file labels consistent on...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.