Problem/Motivation

Styleguide can render available layouts when core Layout discovery module enabled

Proposed resolution

Create plugin for layouts
Decide on defaults for preview generation

Remaining tasks

Add preview, settings for configurable layouts
discus fields to describe layout

User interface changes

CommentFileSizeAuthor
#11 styleguide-layouts.png32.9 KBandypost
styleguide_layout.png46.4 KBandypost
#2 2962486-2.patch4.47 KBandypost
#3 Screen Shot 2018-04-20 at 14.43.49.png254.3 KBfinnsky
#3 2962486-3.patch5.21 KBfinnsky
#3 interdiff_2962486-2-3.txt1.98 KBfinnsky
#4 ds-bug.png111.64 KBfinnsky
#4 grouped_layouts.png179.92 KBfinnsky
#4 2962486-4.patch5.46 KBfinnsky
#4 interdiff_2962486-3-4.txt3.08 KBfinnsky
#5 2962486-5.patch5.41 KBilya.no
#5 interdiff_2962486-5-6.txt272 bytesilya.no
#6 interdiff-2962486-5.txt4.86 KBandypost
#6 2962486-6.patch5.91 KBandypost
#7 interdiff-2962486-6.txt740 bytesandypost
#7 2962486-7.patch5.66 KBandypost
#8 styleguide-layouts.png34.55 KBandypost
#10 interdiff_7-8.txt1.62 KBfinnsky
#10 2962486-8.patch6.02 KBfinnsky

Comments

andypost created an issue. See original summary.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Active » Needs review
Issue tags: +Needs tests
StatusFileSize
new 2962486-2.patch4.47 KB

Initial patch

finnsky’s picture

finnsky commented
StatusFileSize
new Screen Shot 2018-04-20 at 14.43.49.png254.3 KB
new 2962486-3.patch5.21 KB
new interdiff_2962486-2-3.txt1.98 KB

Tests done:
Added bartik custom layout. It is appears in styleguide. OK
Attached custom lib. Appears after patch.

In patch:
Added library used by layout in details list.
Added provider of layout in details list. It seems me important to know.
Added simple rendering. Libraries of layouts attached to styleguide.
Reduced icon size.

What should be done:
Maybe get details with LayoutPluginManager->getLayoutOptions()?
We need to set default markup and maybe add some styles(styleguide only)? To have good display of layouts.
Group layouts by categories.
Add layout modifiers???

finnsky’s picture

finnsky commented
StatusFileSize
new ds-bug.png111.64 KB
new grouped_layouts.png179.92 KB
new 2962486-4.patch5.46 KB
new interdiff_2962486-3-4.txt3.08 KB

1. grouped layouts by categories. so now we have groups names in styleguide menu
2. added wrapped per each layout. collapsible by default.
3. added styleguide only css. based on layout builder styles.

4. found bug with Display suite layouts.

ilya.no’s picture

ilya.no commented
StatusFileSize
new 2962486-5.patch5.41 KB
new interdiff_2962486-5-6.txt272 bytes

Fixed unused class and typo. New plugin looks fine, it's very informative.

andypost’s picture

andypost
he/him
Primary language Russian
commented
StatusFileSize
new interdiff-2962486-5.txt4.86 KB
new 2962486-6.patch5.91 KB

More clean-up

andypost’s picture

andypost
he/him
Primary language Russian
commented
StatusFileSize
new interdiff-2962486-6.txt740 bytes
new 2962486-7.patch5.66 KB 
+++ b/src/Plugin/Styleguide/LayoutStyleguide.php
@@ -0,0 +1,170 @@
+          $layoutInstance = $this->layoutPluginManager->createInstance($definition->id());
+          $details[] = var_export($layoutInstance->getConfiguration(), TRUE);
+          $layoutInstance->setConfiguration($layoutInstance->defaultConfiguration());
+          $details[] = var_export($layoutInstance->defaultConfiguration(), TRUE);

debug removed

andypost’s picture

andypost
he/him
Primary language Russian
commented
Issue summary: View changes
StatusFileSize
new styleguide-layouts.png34.55 KB

Filed follow-up #2978789: Fix render of ds layouts

Updated screenshot - looks it needs float:left for icins & rtl fix for it

andypost’s picture

andypost
he/him
Primary language Russian
commented

Also I think better remove dash border or make it on hover cos layouts could have special classes/modifiers for borders which we override in module's css

finnsky’s picture

finnsky commented
StatusFileSize
new 2962486-8.patch6.02 KB
new interdiff_7-8.txt1.62 KB

Added some css to have layouts looks better. Added container with float.

Found bug when patch enabled without Layout Discovery. Some extra rules should be added, or module dependency.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs tests
StatusFileSize
new styleguide-layouts.png32.9 KB

It looks good to go! displaying borders on hoved - nice idea

  • Oleksiy committed d463ec9 on 8.x-1.x authored by finnsky 
    Issue #2962486 by finnsky, andypost, ilya.no: Add integration to core's...
oleksiy’s picture

oleksiy
Primary language Ukrainian
Location Lutsk 🇺🇦
commented
Status: Reviewed & tested by the community » Fixed
beccaneer’s picture

beccaneer commented

I can no longer use this module unless I have the Layout Discovery module installed.

Here's the error:

The website encountered an unexpected error. Please try again later.</br></br><em class="placeholder">Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException</em>: You have requested a non-existent service &quot;plugin.manager.core.layout&quot;. Did you mean one of these: &quot;plugin.manager.condition&quot;, &quot;plugin.manager.rest&quot;, &quot;plugin.manager.views.sort&quot;? in <em class="placeholder">Drupal\Component\DependencyInjection\Container-&gt;get()</em> (line <em class="placeholder">151</em> of <em class="placeholder">core/lib/Drupal/Component/DependencyInjection/Container.php</em>). <pre class="backtrace">Drupal\styleguide\Plugin\Styleguide\LayoutStyleguide::create(Object, Array, &#039;layout_styleguide&#039;, Array) (Line: 21)
Drupal\Core\Plugin\Factory\ContainerFactory-&gt;createInstance(&#039;layout_styleguide&#039;, Array) (Line: 84)
Drupal\Component\Plugin\PluginManagerBase-&gt;createInstance(&#039;layout_styleguide&#039;, Array) (Line: 98)
Drupal\styleguide\Controller\StyleguideController-&gt;page()
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber-&gt;Drupal\Core\EventSubscriber\{closure}() (Line: 582)
Drupal\Core\Render\Renderer-&gt;executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber-&gt;wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber-&gt;Drupal\Core\EventSubscriber\{closure}() (Line: 151)
Symfony\Component\HttpKernel\HttpKernel-&gt;handleRaw(Object, 1) (Line: 68)
Symfony\Component\HttpKernel\HttpKernel-&gt;handle(Object, 1, 1) (Line: 57)
Drupal\Core\StackMiddleware\Session-&gt;handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\KernelPreHandle-&gt;handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware-&gt;handle(Object, 1, 1) (Line: 52)
Drupal\Core\StackMiddleware\NegotiationMiddleware-&gt;handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel-&gt;handle(Object, 1, 1) (Line: 666)
Drupal\Core\DrupalKernel-&gt;handle(Object) (Line: 19)
andypost’s picture

andypost
he/him
Primary language Russian
commented

Thanks for report, please check the follow-up fix #2981411: Layout discovery enabled checking

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.