While evaluating this module, I noticed the README file lacked some important configurations that would be helpful for those looking to use the module. According to Drupal standards, modules should include a useful README.file https://www.drupal.org/docs/develop/documenting-your-project/readme-temp... to follow

CommentFileSizeAuthor
#5 2847557-5.patch1.46 KBbhanuprakashnani
#4 issues.png144.63 KBAanal.addweb
readme-file-change-2847557-#1.patch1.46 KBpraveenneelu

Comments

Praveen Neelanathan created an issue. See original summary.

Aanal.addweb’s picture

Aanal.addweb commented
Status: Needs review » Reviewed & tested by the community

@Praveen Neelanathan, Thanks for Providing patch, But as per standards, there are some issues which I Reported below.

1) Extra one line above the first section.
2) Numbered lists indented 4 spaces is missing.
3) 2 extra lines at end of the file.
4) Text manually word-wrapped within around 80 cols.

Thanks!.

Aanal.addweb’s picture

Aanal.addweb commented
Status: Reviewed & tested by the community » Needs work
Aanal.addweb’s picture

Aanal.addweb commented
StatusFileSize
new issues.png144.63 KB
bhanuprakashnani’s picture

bhanuprakashnani commented
Status: Needs work » Needs review
StatusFileSize
new 2847557-5.patch1.46 KB

Made the required changes. Please review. Thank you.

Aanal.addweb’s picture

Aanal.addweb commented
Status: Needs review » Reviewed & tested by the community

@bhanuprakashnani, Thank you for the updated patch, It works well for me and it is correct as per standard template.

Thanks again ..!!

bhanuprakashnani’s picture

bhanuprakashnani commented
bhanuprakashnani’s picture

bhanuprakashnani commented

Please give the fixed tag to this issue.

mmjvb’s picture

mmjvb commented

Maintainer needs to apply the patch in order to set Status to Fixed.

saranya ashokkumar’s picture

saranya ashokkumar commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.