The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.Problem/Motivation
While plugins already can provide their own settings within their buildConfigurationForm method, they are not able to directly address form validation or process the settings within the configuration form's submit handler. This currently requires the use of a settings form alter hook, as the provided validate and submit methods of the OpenIDConnectClientBase class are merely unused dummies.
Proposed resolution
Invoke the validateConfigurationForm and submitConfigurationForm of all client plugin classes within the OpenID Connect SettingsForm's validateForm and submitForm methods.
Remaining tasks
Community review.
User interface changes
None.
API changes
None. All methods are already present. They are just not in use. Modules that add submit/validate handlers using a settings form alter hook (e.g. Keycloak) can then rely on these methods.
Data model changes
None.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | openid_connect-2961251-2.patch | 9.69 KB | mario steinitz |
Comments
Comment #2
mario steinitzAttached a patch that adds invokation of the client plugin's validate and submit handlers to the admin settings form.
Comment #3
mario steinitzAdded missing
SubformState::createForSubform()toSettingsForm::buildForm()and tested the patch in conjunction with custom plugin settings and setting preprocessing through the plugin (saving still takes place within the form submit handler).Looks good to me now.
Comment #5
mario steinitz