After upgrading to the alpha9, i got error when access to /admin/commerce/licenses.

seems like with the commit @7eb4ed6 , we should also disable the actions 'entity.commerce_license.add_page' defined in commerce_license.links.action.yml:

entity.commerce_license.add_page:
  route_name: entity.commerce_license.add_page
  title: 'Create license'
  appears_on:
    - entity.commerce_license.collection

comments out those lines will be fine.

CommentFileSizeAuthor
#6 2961037-6.patch849 bytesnikathone
#3 patch_for_7eb4ed6.patch548 bytesfy1128

Comments

fy1128 created an issue. See original summary.

joachim’s picture

Yup, I realized after I made the release I should have taken those out too!

Don't suppose you could post a patch of them commented out?

fy1128’s picture

StatusFileSize
new548 bytes

Here is the patch.

  • joachim committed 791f4ae on 8.x-2.x authored by fy1128
    Issue #2961037 by fy1128: Fixed crash on license collection page due to...
joachim’s picture

Status: Active » Fixed

Thanks!

nikathone’s picture

Status: Fixed » Needs review
StatusFileSize
new849 bytes

Removing the entire commerce_license.links.action.yml Cause getting

The website encountered an unexpected error. Please try again later.</br></br><em class="placeholder">Drupal\Component\Serialization\Exception\InvalidDataTypeException</em>: yaml_parse(): end of stream reached without finding document 0 in <em class="placeholder">Drupal\Component\Serialization\YamlPecl::errorHandler()</em> (line <em class="placeholder">72</em> of <em class="placeholder">core/lib/Drupal/Component/Serialization/YamlPecl.php</em>). <pre class="backtrace">yaml_parse(&#039;# TODO: restore this when the add license UI is fixed.
#entity.commerce_license.add_page:
#  route_name: entity.commerce_license.add_page
#  title: &#039;Create license&#039;
#  appears_on:
#    - entity.commerce_license.collection
&#039;, 0, 0, Array) (Line: 54)
Drupal\Component\Serialization\YamlPecl::decode(&#039;# TODO: restore this when the add license UI is fixed.
#entity.commerce_license.add_page:
#  route_name: entity.commerce_license.add_page
#  title: &#039;Create license&#039;
#  appears_on:
#    - entity.commerce_license.collection
&#039;) (Line: 35)
Drupal\Component\Serialization\Yaml::decode(&#039;# TODO: restore this when the add license UI is fixed.
#entity.commerce_license.add_page:
#  route_name: entity.commerce_license.add_page
#  title: &#039;Create license&#039;
#  appears_on:
#    - entity.commerce_license.collection
&#039;) (Line: 19)
joachim’s picture

Do you maybe have a nonstandard setup? Because I did 'drush cr' with the latest release and it all worked fine.

joachim’s picture

Status: Needs review » Postponed (maintainer needs more info)

I just did a drush cr on a site that's running the latest dev, and the licenses page loads fine for me.

nikathone’s picture

Here is my stack using drupalvm:

PHP 7.0.27-1+ubuntu16.04.1+deb.sury.org+1 (cli) (built: Jan  5 2018 14:12:46) ( NTS )
Copyright (c) 1997-2017 The PHP Group
Zend Engine v3.0.0, Copyright (c) 1998-2017 Zend Technologies
    with Zend OPcache v7.0.27-1+ubuntu16.04.1+deb.sury.org+1, Copyright (c) 1999-2017, by Zend Technologies
    with Xdebug v2.5.0, Copyright (c) 2002-2016, by Derick Rethans
Drupal: 8.5.1
Commerce 2.6.0
Commerce recurring 1.0.0-beta3

Also using php7.0 with relocated doc root on pantheon it's breaking. Is there any particular reason we should keep a file which is not used at all?

chriso’s picture

We (Acquia) have just seen a customer hit the same problem with 8.x-2.0-alpha10 - corrected by the patch in #6.

Acquia Cloud uses the PECL YAML extension. We have a snippet for locating potential sources of the yaml_parse() exceptions on the following article, which helped us locate this issue: https://docs.acquia.com/article/yaml-pecl-serialization-errors

Some background on why this might affect some and not others is here: #1920902: Add a Drupal Yaml wrapper so we can default to PECL Yaml component if it is available

nikathone’s picture

Status: Postponed (maintainer needs more info) » Needs review

Let put this back in needs review...

  • joachim committed 40e8ea8 on 8.x-2.x authored by nikathone
    Issue #2961037 by nikathone: Follow-up: removed menu actions file...
joachim’s picture

Status: Needs review » Fixed

Thanks @chriso for the explanation and @nikathone for the patch!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.