See related D7 issue which was resolved. Seems to be same issue in D8 version.

CommentFileSizeAuthor
#7 2961036-revamp-markup-7.patch26.25 KBnickdickinsonwilde
#5 2961036-revamp-markup-5.patch25.94 KBnickdickinsonwilde
#3 2961036-revamp-markup.patch21.44 KBnickdickinsonwilde

Comments

inteja created an issue. See original summary.

inteja’s picture

inteja commented
Version: 8.x-2.x-dev » 8.x-2.0-rc2
nickdickinsonwilde’s picture

nickdickinsonwilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
commented
Version: 8.x-2.0-rc2 » 8.x-2.x-dev
Status: Active » Needs review
StatusFileSize
new 2961036-revamp-markup.patch21.44 KB

Large patch for testing w drupalci

Status: Needs review » Needs work

The last submitted patch, 3: 2961036-revamp-markup.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

nickdickinsonwilde’s picture

nickdickinsonwilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
commented
Status: Needs work » Needs review
StatusFileSize
new 2961036-revamp-markup-5.patch25.94 KB

Status: Needs review » Needs work

The last submitted patch, 5: 2961036-revamp-markup-5.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

nickdickinsonwilde’s picture

nickdickinsonwilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
commented
Status: Needs work » Needs review
StatusFileSize
new 2961036-revamp-markup-7.patch26.25 KB

  • NickWilde committed 3bad835 on 8.x-2.x 
    Issue #2961036 by NickWilde: Help text for color field not appearing on...
nickdickinsonwilde’s picture

nickdickinsonwilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
commented
Status: Needs review » Fixed

Ended up totally revamping all the widgets. Removed a bunch of custom code and tossed the custom theme functions. Now fairly closely matching the core widgets and added tests and all 5 widgets show their field labels, descriptions, and sub labels if both color and opacity fields are shown.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

anpolimus’s picture

anpolimus
Primary language Ukrainian
Location Kyiv
commented

@NickWilde, your last commit is breaking spectrum widget attachment.
After update to 2.0 version - spectrum is not working.
Our js code for Spectrum is trying to attach his work to the js-color-field-widget-spectrum which is now not exist at the markup.
https://cgit.drupalcode.org/color_field/tree/js/color_field_widget_spect...

rwam’s picture

rwam commented
Related issues: +#3002836: No functionality of the Spectrum widget on Drupal 8.6.x with latest stable or dev

Thanks @anpolimus for your findings. Attach related issue which prevents us from updating.

hhvardan’s picture

hhvardan commented
Related issues: +#3198394: Field label is hidden on spectrum widget.

The approved patch breaks spectrum widget label display.
See the related issue.