Problem/Motivation

OptionsRequestSubscriber uses call_user_func_array() unnecessarily.

Proposed resolution

Remove call_user_func_array(). This event subscriber is fully tested in OptionsRequestSubscriberTest

Remaining tasks

User interface changes

None

API changes

None

Data model changes

CommentFileSizeAuthor
#3 event.png9.89 KBchanderbhushan
#2 2960507-2.patch1.12 KBalexpott

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review
StatusFileSize
new 2960507-2.patch1.12 KB
chanderbhushan’s picture

chanderbhushan commented
StatusFileSize
new event.png9.89 KB

@alexpott, I have tested your patch. working fine.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Too bad we cannot use ..., given this could be used instead, too.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: 2960507-2.patch, failed testing. View results

Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
commented
Status: Needs work » Reviewed & tested by the community

Testbot Snafu.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Priority: Normal » Minor

👌

catch’s picture

catch
he/him
Primary language English
commented
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed e74d54b and pushed to 8.6.x. Thanks!

  • catch committed e74d54b on 8.6.x 
    Issue #2960507 by alexpott: Remove call_user_func_array from...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.