Hi,

I've been importing a complicated shipping arrangements into a new site and noticed that when creating more than 50 shipping methods only the first 50 are shown on the /admin/commerce/config/shipping-methods page.

It's fine to be paginated but it does not appear to be rendering the pagination links.

CommentFileSizeAuthor
#5 2960445-paginate-shipping-methods-5.patch638 bytesmattjones86
#2 2960445-paginate-shipping-methods-1.patch541 bytesmattjones86
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

orphans created an issue. See original summary.

mattjones86’s picture

mattjones86
Location 🇬🇧 GMT+0
CreditAttribution: mattjones86 commented
FileSize
2960445-paginate-shipping-methods-1.patch541 bytes

Easy patch in the end

mattjones86’s picture

mattjones86
Location 🇬🇧 GMT+0
CreditAttribution: mattjones86 commented
Status: Active » Needs review
bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented
Status: Needs review » Needs work 
+    $form['pager'] = array(
+      '#type' => 'pager',
+    );

The D8 coding standard forbids long array usage.

Let's copy the render() method from PromotionListBuilder.

Generally, a pager kinda conflicts with the idea of draggable rows, but let's sync with Commerce first, we can solve it later in both places.

mattjones86’s picture

mattjones86
Location 🇬🇧 GMT+0
CreditAttribution: mattjones86 commented
Status: Needs work » Needs review
FileSize
2960445-paginate-shipping-methods-5.patch638 bytes

Ah I was looking for another example of how this was handled in commerce.

New patch attached.

Status: Needs review » Needs work

The last submitted patch, 5: 2960445-paginate-shipping-methods-5.patch, failed testing. View results

  • bojanz committed de2efb9 on 8.x-2.x authored by orphans 
    Issue #2960445 by orphans, bojanz: Shipping Methods UI does not paginate
bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented
Status: Needs work » Fixed

Fixed the injection of $formBuilder and committed. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.