Deprecate Extension::__call() magic

Now this method caused phpstan to fail so changing to bug, see https://www.drupal.org/pift-ci-job/2520505 and #3015812-112: Introduce new Theme extension object and properly deprecate REGIONS_VISIBLE and REGIONS_ALL

Solution could be add annotation as the issue doing or provide some method to return iterator

The usage is not that big

$ git grep '__call('
core/lib/Drupal/Component/Annotation/Plugin/Discovery/AnnotationBridgeDecorator.php:71:  public function __call($method, $args) {
core/lib/Drupal/Component/Datetime/DateTimePlus.php:351:  public function __call($method, array $args) {
core/lib/Drupal/Component/Plugin/Discovery/DerivativeDiscoveryDecorator.php:250:  public function __call($method, $args) {
core/lib/Drupal/Component/Plugin/Discovery/StaticDiscoveryDecorator.php:63:  public function __call($method, $args) {
core/lib/Drupal/Core/Database/Query/SelectExtender.php:512:  public function __call($method, $args) {
core/lib/Drupal/Core/Extension/Extension.php:166:  public function __call($method, array $args) {
core/lib/Drupal/Core/Plugin/Discovery/InfoHookDecorator.php:59:  public function __call($method, $args) {
core/lib/Drupal/Core/Plugin/Discovery/YamlDiscoveryDecorator.php:49:  public function __call($method, $args) {
core/lib/Drupal/Core/Routing/AccessAwareRouter.php:61:  public function __call($name, $arguments) {
core/modules/migrate/src/Plugin/Discovery/ProviderFilterDecorator.php:95:  public function __call($method, array $args) {
core/modules/migrate/src/Plugin/NoSourcePluginDecorator.php:54:  public function __call($method, array $args) {
core/modules/views_ui/src/ViewUI.php:905:  public function __call($method, $args) {
core/tests/Drupal/Tests/Component/Plugin/Discovery/StaticDiscoveryDecoratorTest.php:186:   *     mocked __call() will return them.

We have a well-proven deprecation workflow, so +1 for the clean solution option 1, to add getSplFileInfo (we can bikeshed on the method name) and deprecate __call.

Let's see if there's a any other calls to it

and debug information

valid patch

So only

• getMTime() used once in runtime and once in api docs
• getCTime() used once in runtime

1. +++ b/core/lib/Drupal/Core/Extension/ExtensionList.php
   @@ -555,7 +555,7 @@ protected function createExtensionInfo(Extension $extension) {
   +    $info['mtime'] = $extension->getFileInfo()->getMTime();
   

   we can deprecate this key as it is not parsed see \Drupal\Core\Utility\ProjectInfo::filterProjectInfo() and used only by tests

2. +++ b/core/lib/Drupal/Core/Utility/ProjectInfo.php
   @@ -81,7 +81,7 @@ public function processInfoList(array &$projects, array $list, $project_type, $s
   +        $file->info['_info_file_ctime'] = $file->getFileInfo()->getCTime();
   

   consumed only by locale and update modules

- 4 usages in contrib http://codcontrib.hank.vps-private.net/search?text=_info_file_ctime&file...
- 2 usages http://codcontrib.hank.vps-private.net/search?text=%27mtime%27&filename=

Hey, that ended up simple!

Code looks straightforward and tests are green.
Added a draft CR.
Added followup for #20.

Deeming RTBC.

Needs to fix link to real cr and add tests somehow

Fixed link to CR and added deprecation test, now looks ready

IS needs to be fixed because I'm using more generic name getFileInfo() instead of mentioning implementation details of SPL (which could be a cause of naming issue for caps/no-caps)

Sad TestBot :(

fix c/p error

Testbot is green, test looks good. Also updated the IS.

+++ b/core/lib/Drupal/Core/Extension/Extension.php
@@ -160,12 +160,25 @@ public function load() {
+  /**
+   * Returns SplFileInfo instance for the extension's info file.
+   */
+  public function getFileInfo(): \SplFileInfo {

Missing @return documentation. I think we should still have this - unless we've changed our coding standards.

Thanks, added

Marking as RTBC as the only changes here are comments. Thanks @andypost.

Committed 5b8e018 and pushed to 10.1.x. Thanks!