Using the drupal_block for a block that returns empty (in the case of Facets when the facet doesn't exist), throws an error because Facets returns an empty array. The drupalBlock method assumes that there is a #cache key even if the block is empty.

CommentFileSizeAuthor
#6 twig_tweak-block-cache-check-2958571-6.patch440 bytesprashant.c
#2 twig_tweak-block-cache-check-2958571-1.patch473 byteselgordogrande

Comments

elgordogrande created an issue. See original summary.

elgordogrande’s picture

elgordogrande commented
StatusFileSize
new twig_tweak-block-cache-check-2958571-1.patch473 bytes

Here is a patch that includes the error check.

chi’s picture

chi commented

Is empty string a valid value for #cache property? I propose we use empty array instead.

fabianx’s picture

fabianx commented
Status: Needs review » Needs work

Yes, needs to be an array.

alesbencina’s picture

alesbencina commented

Is this issue solved in twig_tweak 8.x-2.0?

prashant.c’s picture

prashant.c
he/him
Primary language English
Location Dharamshala
commented
Status: Needs work » Needs review
StatusFileSize
new twig_tweak-block-cache-check-2958571-6.patch440 bytes

@elgordogrande

Thanks for the initial patch.

@Fabianx

Suggested change is done, please review.

  • Chi committed 40d9540 on 8.x-2.x authored by Prashant.c 
    Issue #2958571 by elgordogrande, Prashant.c, Fabianx: DrupalBlock cache...
chi’s picture

chi commented
Version: 8.x-2.0-rc4 » 8.x-2.x-dev
Status: Needs review » Fixed

Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.