While evaluating this module, we noticed a typo in the README files.

Converstion => Conversion

Patch to follow, thanks!

CommentFileSizeAuthor
#8 interdiff-2957724-2-8.txt5.32 KBvolkswagenchick
#8 google_adwords-d7-add-readme-2957723-8.patch5.32 KBvolkswagenchick
#5 google_adwords-d7-add-readme-2957723-5.patch1.09 KBaadil.addweb
#4 Before_adword.png4.05 KBzalak.addweb
#4 After_adword.png4.05 KBzalak.addweb
#4 Typo_adword_d7.png5.4 KBzalak.addweb
#2 google_adwords-d7-add-readme-2957723-2.patch1.6 KBvolkswagenchick

Comments

volkswagenchick created an issue. See original summary.

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
Status: Active » Needs review
StatusFileSize
new google_adwords-d7-add-readme-2957723-2.patch1.6 KB

I uploaded a patch that fixes the typos in the READMEs. Thanks.

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
Assigned: volkswagenchick » Unassigned
zalak.addweb’s picture

zalak.addweb commented
Status: Needs review » Needs work
StatusFileSize
new Typo_adword_d7.png5.4 KB
new After_adword.png4.05 KB
new Before_adword.png4.05 KB

@volkswagenchick, Thanks for correcting this typo errors, I checked it manually & found one more typo from the ReadMe file.
PFA in which i mentioned that:

REQUIREMENTS
------------
* Google Adwords Acccount

should be

REQUIREMENTS
------------
* Google Adwords Account
aadil.addweb’s picture

aadil.addweb commented
Status: Needs work » Needs review
StatusFileSize
new google_adwords-d7-add-readme-2957723-5.patch1.09 KB

@Disha.addweb, Thanks for your findings, I corrected the issue.
Please Check my uploaded patch & let me know.

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
Status: Needs review » Needs work

One nitpick

+++ b/README.txt
@@ -30,7 +30,7 @@ INSTALLATION INSTRUCTIONS
+    supply the "Conversion label" that Google Adwords gave you when you setup ¶

there is an extra space at the end of line 34

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented 
+++ b/README.txt
@@ -5,8 +5,8 @@ advanced ROI reports with Google Adwords
+* An existing Conversion tracking in your Google Adwords account (you will ¶

And another extra space at the end of line 10

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
Status: Needs work » Needs review
StatusFileSize
new google_adwords-d7-add-readme-2957723-8.patch5.32 KB
new interdiff-2957724-2-8.txt5.32 KB

Funny, I was concentrated on the one typo that I didn't see any other errors. Looking back there were extra spaces at the end on the lines which do not align to documentation standards.

I uploaded a new patch that addresses the type and removes the extra spaces. Thanks for review ing this everyone!

I also attached an interdifff between my two patches.

dani3lr0se’s picture

dani3lr0se commented
Status: Needs review » Reviewed & tested by the community

The new patch in #8 applies cleanly. It addresses the typo along with the extra spaces. I no longer see the extra spaces. I didn't notice any other typos either. Looks good. Thanks for the patch @volkswagenchick.

perignon’s picture

perignon commented

Thanks for the patch!

perignon’s picture

perignon commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.