Problem/Motivation

I recently updated a local development site from 8.5.0 to 8.5.1. The site was pretty much just Drupal Core, and I had the Testing (simpletest) module enabled.

I did the update by downloading the .tar.gz tarball from drupal.org, and replacing the core, vendor, and top-level files from my existing installation with the new files. This included the composer.json and composer.lock files.

Then I went to update.php to run database updates. I saw a message saying:

Requirements problem

PHPUnit dependency

The testing framework requires the PHPUnit package. Please run 'composer install --dev' to ensure it is present.

So I went to the command line and ran

composer install --dev

This worked fine, but it gave me a message saying:

You are using the deprecated option "dev". Dev packages are installed by default now.

So, it seems like the requirements message needs an update to remove the --dev option from the suggested command.

Proposed resolution

Find out where this message is being generated that says to run composer with --dev. Remove the --dev option from the command.

Remaining tasks

Make a patch.

User interface changes

The message telling you to run composer install will not tell you that you need to use the --dev option.

API changes

None.

Data model changes

None.

Comments

jhodgdon created an issue. See original summary.

jhodgdon’s picture

Issue summary: View changes

fix HTML formatting in summary.

pifagor’s picture

Assigned: Unassigned » pifagor
pifagor’s picture

Status: Active » Needs review
StatusFileSize
new1.27 KB
pifagor’s picture

Assigned: pifagor » Unassigned
jhodgdon’s picture

Priority: Normal » Minor
Status: Needs review » Reviewed & tested by the community

Thanks! This looks like exactly the right patch to me, and I verified that these are the only two places that --dev suggestion is made, as far as I can tell.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

This was done in https://github.com/composer/composer/blob/master/CHANGELOG.md#100-alpha8... so yeah I agree we should change this.

Crediting @jhodgdon for opening the issue.

Committed and pushed b9a310e29e to 8.6.x and 6f21164b71 to 8.5.x. Thanks!

Backported to 8.5.x since this is text only change to test code.

  • alexpott committed b9a310e on 8.6.x
    Issue #2957367 by pifagor, jhodgdon: Message on PHPUnit requirements...

  • alexpott committed 6f21164 on 8.5.x
    Issue #2957367 by pifagor, jhodgdon: Message on PHPUnit requirements...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.