Fix typo in locale_config_batch_refresh_name causing "[warning] No configuration objects have been updated."

Re-rolled for 9.4.

Having the same issue on install with other languages. rather than the default English selected language.
Have a custom .po file with the profile and modules too.
Trying to import it on the installation steps.

I get this regularly when using demo_umami and installing modules.

I am getting this error when enabling a new custom module on Drupal 9.5.10. The site is an old Drupal 8 site that has been upgraded to Drupal 9 a year back & it's a minimal Drupal profile. The steps that I performed were:

• Created a new custom module directory & the info yml file.
• Added custom migration yml in config/install directory. (Note: I don't have any other config files in config/install.)
• In CLI, I did drush en - y custom_module_name and got the notice & warning saying No configuration objects have been updated..
• Despite the notice & warning, The module gets enabled.

Even after applying the patches, The issue remains.

I am getting this message when a module is enabled (Drupal 9.5.10)
> [notice] Checked es translation for admin_toolbar.
> [warning] No configuration objects have been updated.
> [notice] Message: No configuration objects have been updated.

Module enabled successfully, despite these notices/warnings

This is caused by a typo in locale_config_batch_refresh_name() ... all the back in #1905152: Integrate config schema with locale, so shipped configuration is translated

Posted MR with fix.

Nice finding

Wow, nice find indeed 😊

Yay! Such a simple fix 👏

Wow, Great Find. That was quick 🎉

I'm triaging RTBC issues. I read the IS which should have a proposed resolution so reviewers understand the fix. I considered stopping there but this is a bit older and only 26 comments. After reading the comments I have updated the issue summary.

I ran the test only changes and it does fail on checking the count of error messages, not the error message in the IS. I ran the test only version locally and it does indeed fail with a message of "No configuration objects have been updated."

I reviewed the MR and everything if fine there.

Leaving at RTBC.

A more accurate title.

Indeed, this is a nice find.

Pushed to 11.x and 10.2.x Thanks!

Seems this patch got reverted for some reason?
Cuz now I see this message again with the "warning" severity in Drupal 11.1.8 (and in 10.2.x too): https://git.drupalcode.org/project/drupal/-/blob/11.1.8/core/modules/loc...

function locale_config_batch_finished($success, array $results) {
  if ($success) {
    $configuration = $results['stats']['config'] ?? 0;
    if ($configuration) {
      \Drupal::messenger()->addStatus(t('The configuration was successfully updated. There are %number configuration objects updated.', ['%number' => $configuration]));
      \Drupal::logger('locale')->notice('The configuration was successfully updated. %number configuration objects updated.', ['%number' => $configuration]);
    }
    else {
      \Drupal::messenger()->addStatus(t('No configuration objects have been updated.'));
      \Drupal::logger('locale')->warning('No configuration objects have been updated.');
    }
  }
}