Closed (fixed)
Project:
Translation Views
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
30 Mar 2018 at 04:10 UTC
Updated:
9 Oct 2018 at 21:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
matsbla commentedComment #3
matsbla commentedComment #4
ajay_reddyComment #5
matsbla commentedI tested patch manually and I still get the "Add" translation operation button, even though there is draft translation there.
I also update the issue description.
Comment #6
ajay_reddyComment #7
matsbla commentedMaybe we can try put a check for pending revisions out in a function?
Comment #8
ajay_reddyComment #9
matsbla commentedRemove indentention changes.
Comment #10
matsbla commentedThis patch is working for me.
Comment #11
matsbla commentedComment #12
matsbla commentedUpdated patch with first attempt to provide translation moderation fields and filters in view.
Comment #13
ajay_reddyComment #14
ajay_reddyComment #15
ajay_reddyComment #16
ajay_reddyComment #17
ajay_reddyComment #18
ajay_reddyComment #19
ajay_reddyComment #20
ajay_reddyComment #21
ajay_reddyComment #22
ajay_reddyComment #23
matsbla commentedThanks!
Adding some configs for tests
Comment #24
matsbla commentedComment #25
valentine94Hi there!
Here is an updated patch with the following changes:
- fixed missing schema error
- fixed incorrect code styling
- fixed new field plugin code readability
- replaced using \Drupal::service() with DependencyInjection for plugins
- created test for content moderation integration
Could you review that one, please?
Thanks, Valentine
Comment #26
matsbla commentedThanks for the updated patch with tests. I looked over and tested it and looks pretty good. I'm making some small updates to the patch. I've turned off sorting for the field as this is not yet supported for moderation states, I've created a follow up issue for that later #3002318: Make translation moderation state field sortable. Also I've updated readme file and made the field title lowercase.
Comment #27
matsbla commentedAlso make a follow up issue to add translation moderation state filters later:
#3002331: Make a filter for translation moderation states
Comment #29
matsbla commentedThanks for the great work on this!