Comments

matsbla created an issue. See original summary.

matsbla’s picture

Title: Make Translation Views work for pending revisions » Make Translation Views operation links work for pending revisions
Issue summary: View changes
matsbla’s picture

Title: Make Translation Views operation links work for pending revisions » Make operation links work for pending revisions
ajay_reddy’s picture

Status: Active » Needs review
StatusFileSize
new10.4 KB
matsbla’s picture

Issue summary: View changes

I tested patch manually and I still get the "Add" translation operation button, even though there is draft translation there.

I also update the issue description.

ajay_reddy’s picture

StatusFileSize
new4.94 KB
matsbla’s picture

StatusFileSize
new1.94 KB

Maybe we can try put a check for pending revisions out in a function?

ajay_reddy’s picture

StatusFileSize
new7.53 KB
matsbla’s picture

StatusFileSize
new4.82 KB

Remove indentention changes.

matsbla’s picture

StatusFileSize
new3.91 KB

This patch is working for me.

matsbla’s picture

StatusFileSize
new2.69 KB
matsbla’s picture

StatusFileSize
new4.32 KB

Updated patch with first attempt to provide translation moderation fields and filters in view.

ajay_reddy’s picture

StatusFileSize
new5.31 KB
ajay_reddy’s picture

StatusFileSize
new5.48 KB
ajay_reddy’s picture

StatusFileSize
new5.58 KB
ajay_reddy’s picture

StatusFileSize
new7.45 KB
ajay_reddy’s picture

StatusFileSize
new7.74 KB
ajay_reddy’s picture

StatusFileSize
new7.49 KB
ajay_reddy’s picture

StatusFileSize
new8.63 KB
ajay_reddy’s picture

StatusFileSize
new8.61 KB
ajay_reddy’s picture

StatusFileSize
new8.74 KB
ajay_reddy’s picture

StatusFileSize
new8.98 KB
matsbla’s picture

StatusFileSize
new13.17 KB

Thanks!
Adding some configs for tests

matsbla’s picture

Title: Make operation links work for pending revisions » Integrate module with Content Moderation
Issue summary: View changes
valentine94’s picture

StatusFileSize
new22.06 KB

Hi there!

Here is an updated patch with the following changes:

- fixed missing schema error
- fixed incorrect code styling
- fixed new field plugin code readability
- replaced using \Drupal::service() with DependencyInjection for plugins
- created test for content moderation integration

Could you review that one, please?

Thanks, Valentine

matsbla’s picture

StatusFileSize
new22.67 KB

Thanks for the updated patch with tests. I looked over and tested it and looks pretty good. I'm making some small updates to the patch. I've turned off sorting for the field as this is not yet supported for moderation states, I've created a follow up issue for that later #3002318: Make translation moderation state field sortable. Also I've updated readme file and made the field title lowercase.

matsbla’s picture

Also make a follow up issue to add translation moderation state filters later:
#3002331: Make a filter for translation moderation states

  • matsbla committed 395a6b5 on 8.x-1.x
    Issue #2957229 by ajay_reddy, matsbla, Valentine94: Integrate module...
matsbla’s picture

Status: Needs review » Fixed

Thanks for the great work on this!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.