Services in ListWidget and ReferenceWidget should use dependency injection.

CommentFileSizeAuthor
#13 select_or_other_di_plugins-2957040-13.patch2.77 KBigork96
#9 functionalTests.png32.78 KBTauany Bueno
#9 UniTests.txt19.24 KBTauany Bueno
#2 select_or_other_di_plugins_2957040_2.patch6.35 KBnkoporec

Issue fork select_or_other-2957040

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

nkoporec created an issue. See original summary.

nkoporec’s picture

nkoporec
Primary language English
Location Slovenia
commented
Assigned: nkoporec » Unassigned
Status: Active » Needs review
StatusFileSize
new select_or_other_di_plugins_2957040_2.patch6.35 KB

Created a patch.

Status: Needs review » Needs work

The last submitted patch, 2: select_or_other_di_plugins_2957040_2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

saphemmy’s picture

saphemmy commented
Component: Miscellaneous » Code
Assigned: Unassigned » saphemmy
saphemmy’s picture

saphemmy commented
Assigned: saphemmy » Unassigned

I believe the above patch failed because of a non-review of the tests after enforcing DI in #2957040-2: Dependency Injection issues in Plugins. I propose the tests be fixed before submitting a patch for this issue.

aldairsoares’s picture

aldairsoares commented
Assigned: Unassigned » aldairsoares

I'm going to work on it.

Tauany Bueno’s picture

Tauany Bueno commented
Assigned: aldairsoares » Tauany Bueno

hi!
i'm going to work on it :)

tauanygb opened merge request !7

Tauany Bueno’s picture

Tauany Bueno commented
Assigned: Tauany Bueno » Unassigned
StatusFileSize
new UniTests.txt19.24 KB
new functionalTests.png32.78 KB

Hello!
I applied the patch and all DI problems were fixed. I found some PHPCS errors that I fixed.
Regarding the tests, i made some corrections on the Functional tests and now they are all passing. However, the unit tests still have some errors that i wasn't able to fix, so i'm leaving the status as needs work.

jobsons’s picture

jobsons commented

Fixing some of the phpcs errors and warnings about missing documentation

michelecris’s picture

michelecris commented
Assigned: Unassigned » michelecris

Hi!
I will work on that.

michelecris’s picture

michelecris commented
Version: 8.x-1.x-dev » 4.x-dev
Assigned: michelecris » Unassigned

The change should be made on the 4.x branch.

igork96’s picture

igork96 commented
Status: Needs work » Needs review
StatusFileSize
new select_or_other_di_plugins-2957040-13.patch2.77 KB

Here is a patch against 4.x-dev branch. Please review it.

Status: Needs review » Needs work

The last submitted patch, 13: select_or_other_di_plugins-2957040-13.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

hmendes’s picture

hmendes commented

This problem was fixed on #3324088: Drupal Coding Standards Issues | phpcs

hmendes’s picture

hmendes commented
Status: Needs work » Fixed

I'll be fixing this one and giving credits to you, as you all worked in this problem too.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

ivnish closed merge request !7