Problem/Motivation

Umami styles are leaking to the Settings Tray edit button.

Proposed resolution

It would probably bebetter if this fixed in toolbar module / stable.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#13 2956949-13.patch503 bytesrobindh
#7 interdiff_5-7.txt1001 bytesvolkerk
#7 2956949-7.patch918 bytesvolkerk
#5 toolbar-font-family-2956949-5.patch548 bytesmic79
Screen Shot 2018-03-29 at 16.20.09.png22.26 KBlauriii

Comments

lauriii created an issue. See original summary.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Parent issue: » #2940585: Enable Settings Tray on Umami Demo now it has been marked stable in core
volkerk’s picture

volkerk commented

Umami changes font-family for buttons.
Do we want to make buttons styles more specific or alternatively add an override for the toolbar button.

mic79’s picture

mic79 commented

Looking into this right now at DrupalCon (Out of the box table).

mic79’s picture

mic79 commented
StatusFileSize
new toolbar-font-family-2956949-5.patch548 bytes

Added CSS to make the toolbar inherit the font-family so it doesn't use the Umami font.

mic79’s picture

mic79 commented
Status: Active » Needs review
Issue tags: +Nashville2018
volkerk’s picture

volkerk commented
Issue summary: View changes
StatusFileSize
new 2956949-7.patch918 bytes
new interdiff_5-7.txt1001 bytes

Fix in toolbar module / stable theme.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Needs review » Needs work

Thank you for picking up this issue!

Is there a specific reason we are setting styles for html elements by their type or, other properties than classes? That kind of selectors are generally too global and could affect styles in many other ways than what we are seeing in this bug report. A more robust solution for fixing this issue would be to remove all instances of setting styles for pure html elements or properties. To scope this issue, let's start with buttons in this issue.

volkerk’s picture

volkerk commented

I don't know, the font-family issue here stems from a very specific implementation for the button element in base.css:

button,
.button,
[type='button'],
[type='reset'],
[type='submit'] {
  background-color: #00836d;
  border: 3px solid #00836d;
  border-radius: 4px;
  color: #fff;
  cursor: pointer;
  display: inline-block;
  padding: 0.4em 1.5em;
  text-align: center;
  text-decoration: none;
  font-family: 'Scope One', Georgia, serif;
  font-size: 1.2rem;
  font-weight: 400;
  font-weight: normal;
  transition: background-color 0.5s ease;
}

As far as I can see the only button (actually "input.button") utilizing these styles in demo_umami is the submit of the search-block-form.
Unfortunately there are no comments in that file and git commit points to #2809635: Create experimental installation profile.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

eli-t’s picture

eli-t
he/him
Primary language English
Location Manchester
commented
Issue tags: +Drupal Europe, +Out of the Box Initiative

Following discussion with @lauriii, we should remove all targets except .button from the selector hightlighted in #9, then regression test the Umami demo to make sure we are adding that class in all required cases.

gvert’s picture

gvert commented

Robindh and I are working on this at DrupalEurope.

robindh’s picture

robindh commented
StatusFileSize
new 2956949-13.patch503 bytes

I've removed all selectors but ".button" from the css rule described in #9.

robindh’s picture

robindh commented
Status: Needs work » Needs review
gvert’s picture

gvert commented

I've tested the patch in #13, and everything looks good.
The "edit" button has the correct font-family now, and all the other buttons in the umami the still have the correct styling!

markconroy’s picture

markconroy commented
Status: Needs review » Reviewed & tested by the community

This looks good to me. Marking as RTBC.

  • lauriii committed c66f665 on 8.7.x 
    Issue #2956949 by volkerk, mic79, robindh, lauriii, Gvert, Eli-T,...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Reviewed & tested by the community » Fixed

Committed c66f665 and pushed to 8.7.x. Also cherry-picked to 8.6.x. Thanks! 🚀. See you at #2940585: Enable Settings Tray on Umami Demo now it has been marked stable in core!

  • lauriii committed 89b92c5 on 8.6.x 
    Issue #2956949 by volkerk, mic79, robindh, lauriii, Gvert, Eli-T,...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.