CommentFileSizeAuthor
#15 ReadMe_Error1.png11.29 KBzalak.addweb
#12 2956926-12.patch2.46 KBnishantkumar155
#11 2956926-11.patch2.45 KBnishantkumar155
#5 interdiff_2956926_3-2956926-3.txt2.45 KBnishantkumar155
#2 2956926-2.patch2.44 KBnishantkumar155

Comments

nishantkumar155 created an issue. See original summary.

nishantkumar155’s picture

nishantkumar155 commented
Status: Active » Needs review
StatusFileSize
new 2956926-2.patch2.44 KB

Please review my patch #2

neeraprajapati’s picture

neeraprajapati commented
Status: Needs review » Needs work

Patch applied successfully but Please refer this link for README.txt format.

bhanuprakashnani’s picture

bhanuprakashnani commented
Assigned: nishantkumar155 » bhanuprakashnani
Status: Needs work » Needs review
StatusFileSize
new 2956926-3.patch2.87 KB

There were some grammatical mistakes which I have corrected. Troubleshooting section was not there, so added it. Gave correct indentations as per the README template. Mention if any more changes are to be made. Thank you.

nishantkumar155’s picture

nishantkumar155 commented
Assigned: bhanuprakashnani » nishantkumar155
StatusFileSize
new interdiff_2956926_3-2956926-3.txt2.45 KB

Please review again.

bhanuprakashnani’s picture

bhanuprakashnani commented

In the introduction part
This module will show whether your keyboard Capslock is enabled or not.

Give the link for cloning the git repository in the installation section

Message spelling in configuration section

Add the section of troubleshooting

Make the first change in the info.yml file also

bhanuprakashnani’s picture

bhanuprakashnani commented

The above interdiff is not showing the diff whereas it is same as the first patch you uploaded.

bhanuprakashnani’s picture

bhanuprakashnani commented

You can have my patch as reference if you want. I have made the necessary corrections with explanation in the comment.

nishantkumar155’s picture

nishantkumar155 commented

@BHANUPRAKASHNANI Thanks for your patch but this is not good practice to remove an assignee and add yourself, I have re-assign this issue to me and working on the same.

bhanuprakashnani’s picture

bhanuprakashnani commented

ok. Sorry, @nishantkumar155. You can continue. Just wanted to help. ntg else.

nishantkumar155’s picture

nishantkumar155 commented
StatusFileSize
new 2956926-11.patch2.45 KB

please review my patch.

nishantkumar155’s picture

nishantkumar155 commented
StatusFileSize
new 2956926-12.patch2.46 KB

Sorry for last patch # 11, that's the wrong patch.
Please review #12 patch.

neeraprajapati’s picture

neeraprajapati commented
Status: Needs review » Reviewed & tested by the community

Looks good.

bhanuprakashnani’s picture

bhanuprakashnani commented

There are typos in the patch.

zalak.addweb’s picture

zalak.addweb commented
Status: Reviewed & tested by the community » Needs work
StatusFileSize
new ReadMe_Error1.png11.29 KB

@nishantkumar155 thanks for providing the patch, but your patch still has some standard issues which are below:
1) In configuration section, the path must be shown using ">".
2) Extra 1 space before full stop in configuration section.
3) In configuration section, it should be "Type a/your message." instead of "Type you message ."
please review the attached screenshot.

mahipal46’s picture

mahipal46 commented

Grammatical mistake configuration section, it should be "Type a/your message." instead of "Type you message ."

  • nishantkumar155 committed d2a8e34 on 8.x-1.x 
    Issue #2956926 by nishantkumar155, Disha.addweb, neeraprajapati,...
nishantkumar155’s picture

nishantkumar155 commented
Status: Needs work » Fixed

Thank you Disha.addweb , BHANUPRAKASHNANI and mahipal46 .

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.