Fix all the PHPCS errors to meet Drupal standard & practices
pareview.sh
phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md
phpcs --standard=DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md fbl

CommentFileSizeAuthor
#4 2956631-4.patch6.29 KBnishantkumar155
#3 patch-apply2.jpg257.79 KBneeraprajapati
#2 2956631-2.patch6.29 KBnishantkumar155

Comments

nishantkumar155 created an issue. See original summary.

nishantkumar155’s picture

nishantkumar155 commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new 2956631-2.patch6.29 KB

Review my patch #2

neeraprajapati’s picture

neeraprajapati commented
Status: Needs review » Needs work
StatusFileSize
new patch-apply2.jpg257.79 KB

This patch is not working for Drupal errors. Please refer to this attached screenshot.

nishantkumar155’s picture

nishantkumar155 commented
Status: Needs work » Needs review
StatusFileSize
new 2956631-4.patch6.29 KB

@neeraprajapatiI am attaching new patch please review again.

neeraprajapati’s picture

neeraprajapati commented
Status: Needs review » Reviewed & tested by the community

Great! now it's working.

  • nishantkumar155 committed bf86ec3 on 8.x-1.x 
    Issue #2956631 by nishantkumar155, neeraprajapati: Fix PHPCS errors
nishantkumar155’s picture

nishantkumar155 commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.