Closed (fixed)
Project:
Schema.org Metatag
Version:
8.x-1.x-dev
Component:
Miscellaneous
Priority:
Normal
Category:
Plan
Assigned:
Unassigned
Reporter:
Created:
25 Mar 2018 at 15:49 UTC
Updated:
18 Jul 2019 at 21:39 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
karens commentedAlmost all of these are available, but not all of these are top level modules.
BlogPosting is an option in Article, schema_article module.
LocalBusiness are options in Organization, schema_organization module.
AggregateRating is a property available on almost all modules (Recipe, Article, Organization, etc.).
PostalAddress is a property available in many places, like Organization. It's also a part of Place, which is available for Event, JobPosting and others.
Offer is a property available in many places, like on Product and Service.
The only thing in your list that doesn't exist anywhere is Blog. Which could be created as a generic CreativeWork for the odds and end of CreativeWorks that aren't already represented.
Comment #3
karens commentedAlso if you want to get some idea of what is available, check out the new demo site (link on the project page). That has a lot of content types populated with JSON-LD data. You can view the source of each page to see some of the options that can be implemented (there are so many options that not all are implemented even in the demo). The demo also has links so you can check the markup on Google's structured data test tool to see what Google thinks of it.
Another place to see some of what's available is on the new developer documentation page, https://www.drupal.org/docs/8/modules/schemaorg-metatag/developer-instru....
Comment #4
christophweber commentedAs far as I'm concerned the support for the non-obvious schemas is exactly where it needs to be. As outlined by Karen, AggregateRating, BlogPosting, Local Business, Offer and Postal Address are within other schemas where many practitioners would expect them. For example, I have never seen AggregateRating used in isolation, but on countless sites using Recipe, Product, LocalBusiness(Organization) and other schemas. The linked Twitter thread also makes this clear if you read further down.
What we could do better is mention these often used schemas in the docs and possibly in help text to guide newcomers. I'm going to think this through a bit more and see what can be done.
That leaves Blog, which should have its own issue opened to track progress.
Comment #5
simon georges commentedWow, the module is a lot bigger than what I've seen during my last tests ! Indeed, it seems this issue was not at all necessary ;-)
Comment #6
hudat commentedThe local business option is available within organization, but it does not capture all the properties. Particularly, I'm looking for the parentOrganization property
Has anyone been able to include this property with the organization object? Doesn't seem like there are any other objects that would include it
Comment #7
didebruI still miss the articleBody key.
https://search.google.com/structured-data/testing-tool/u/0/#url=http%3A%...
And a token that provides the full rendered article, would be nice.
Comment #8
damienmckennaYou should take that up with the Token maintainers, that'd be the best place for a generic "render the whole thing" token.
Comment #9
didebrudone -> https://www.drupal.org/project/token/issues/2972673#comment-12612947
Comment #10
damienmckennaThanks.
Comment #11
didebruAdded the articleBody Plugin, maybe the description should be written else.
Comment #12
didebruComment #14
karens commentedThis should not extend SchemaMainEntityOfPageBase, it should extend SchemaNameBase.
Comment #15
didebruComment #16
didebruand the interdiff
Comment #17
didebruand the interdiff
Comment #19
karens commentedYour label description says that this field is RECOMMENDED BY GOOGLE, which it is not, see https://developers.google.com/search/docs/data-types/article which does not list it. There are many many fields that are in the schema model and they can't all be added without making this module huge, so my focus is on the fields that Google recommends or requires in their structured data docs. The body field would not be one of those.
You can easily create a small custom module to add this or any other field, using the example module provided. That way the code does not become loaded with tons of fields that are not of general use. The patch illustrates the right way to go about this, by extending SchemaNameBase (a base for simple text fields).
So I'm not going to add this to the module. And looking at this issue I think it has run its course. Rather than adding more fields this way, each should be its own issue.
So I'm marking this issue, which is a plan, not a bug or feature, as fixed. Just to clean up the issue queue so it consists of actionable issues.