CommentFileSizeAuthor
#3 without patch.png32.66 KBakash.addweb
#3 with patch.png24.56 KBakash.addweb
#2 2955755-2.patch306 bytesmohit1604

Comments

mohit1604 created an issue. See original summary.

mohit1604’s picture

mohit1604 commented
Status: Active » Needs review
StatusFileSize
new 2955755-2.patch306 bytes
akash.addweb’s picture

akash.addweb commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new with patch.png24.56 KB
new without patch.png32.66 KB

@mohit1604, Thanks for the patch, your patch works well for me. I checked it over simplytest.me & attached the screenshot for the same.

mohit1604’s picture

mohit1604 commented
Parent issue: » #2955692: [META] Port Glossary module to Drupal 8

  • mohit1604 committed f6c54fe on 8.x-1.x 
    Issue #2955755 by mohit1604,Ronak.addweb: make glossary.info.yml file
mohit1604’s picture

mohit1604 commented
Status: Reviewed & tested by the community » Fixed
akash.addweb’s picture

akash.addweb commented

@mohit1604, Thanks for comitting the patch, but in my profile credit is not visible. To provide me credit you have to select me on "Credit & Comitting" section & than after your commit, credit will visible to me on my profile. Can you please do the needful!.

  • mohit1604 committed 97d4922 on 8.x-1.x 
    Issue #2955755 by mohit1604, Ronak.addweb: Make info.yml file for...
  • mohit1604 committed ad3405c on 8.x-1.x
    Issue #2955755 by mohit1604, Ronak.addweb: Make info.yml file for...

  • mohit1604 committed c6f3fb7 on 8.x-1.x 
    Issue #2955755 by mohit1604, Ronak.addweb: Make info.yml file for...
mohit1604’s picture

mohit1604 commented
mohit1604’s picture

mohit1604 commented
Version: 7.x-1.x-dev » 8.x-1.x-dev

@Ronak.addweb, thanks for working on this. I have provided credit to you. There are other issues for glossary waiting for review, have a look at them.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.