We have a site that has content types with link fields (https://www.drupal.org/project/link) that point to PDF files. We wanted to be able to use this fields without needing to save the PDFs in the filesystem so we created a small submodule for this.

CommentFileSizeAuthor
search_api_attachments_links.tar_.gz2.63 KBjackbravo

Comments

jackbravo created an issue. See original summary.

izus’s picture

izus commented
Status: Needs review » Needs work

Thanks
Please provide a patch instead of an archive

  • izus committed 0c80af2 on 7.x-1.x authored by jackbravo 
    Issue #2955610 by jackbravo, izus: Add a submodule to allow indexing...
  • izus committed 3d0db4c on 7.x-1.x
    Issue #2955610 by izus: Some fixes to search_api_attachments_links
izus’s picture

izus commented
Status: Needs work » Fixed

hi,
hi i reviewed the module and Just for sharing what i changed :
- the .info file has a version, datestamp and project keys that are not needed
- missing word in README
-

i made two separate commits so that you have a full commit author credits

  • izus committed 1efd40b on 7.x-1.x 
    Issue #2955610 by izus: Add search_api_attachments_links to the toot...
jackbravo’s picture

jackbravo commented

Great! Thanks. The only think that maybe would be worth mentioning in the README or somewhere is that this approach has a performance penalty.

izus’s picture

izus commented

HI,
thanks
please add a patch to README file of search_api_attachments_links to mention this and explain why
Thanks again ;)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.