After enabling the module , I can't save user admin form.
Getting this error:
ArgumentCountError: Too few arguments to function uiplog_user_delete_form_submit(), 2 passed and exactly 3 expected in uiplog_user_delete_form_submit() (line 30 of /var/www/html/web/modules/contrib/uiplog/uiplog.module) #0 [internal function]: uiplog_user_delete_form_submit(Array, Object(Drupal\Core\Form\FormState)) #1 /var/www/html/web/core/lib/Drupal/Core/Form/FormSubmitter.php(111): call_user_func_array('uiplog_user_del...', Array) #2 /var/www/html/web/core/lib/Drupal/Core/Form/FormSubmitter.php(51): Drupal\Core\Form\FormSubmitter->executeSubmitHandlers(Array, Object(Drupal\Core\Form\FormState)) #3 /var/www/html/web/core/lib/Drupal/Core/Form/FormBuilder.php(585): Drupal\Core\Form\FormSubmitter->doSubmitForm(Array, Object(Drupal\Core\Form\FormState)) #4 /var/www/html/web/core/lib/Drupal/Core/Form/FormBuilder.php(314): Drupal\Core\Form\FormBuilder->processForm('user_admin_sett...', Array, Object(Drupal\Core\Form\FormState)) #5 /var/www/html/web/core/lib/Drupal/Core/Controller/FormController.php(74): Drupal\Core\Form\FormBuilder->buildForm('user_admin_sett...', Object(Drupal\Core\Form\FormState)) #6 [internal function]: Drupal\Core\Controller\FormController->getContentResult(Object(Symfony\Component\HttpFoundation\Request), Object(Drupal\Core\Routing\RouteMatch)) #7 /var/www/html/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(123): call_user_func_array(Array, Array) #8 /var/www/html/web/core/lib/Drupal/Core/Render/Renderer.php(582): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() #9 /var/www/html/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(124): Drupal\Core\Render\Renderer->executeInRenderContext(Object(Drupal\Core\Render\RenderContext), Object(Closure)) #10 /var/www/html/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(97): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) #11 /var/www/html/vendor/symfony/http-kernel/HttpKernel.php(151): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() #12 /var/www/html/vendor/symfony/http-kernel/HttpKernel.php(68): Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object(Symfony\Component\HttpFoundation\Request), 1) #13 /var/www/html/web/core/lib/Drupal/Core/StackMiddleware/Session.php(57): Symfony\Component\HttpKernel\HttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #14 /var/www/html/web/core/lib/Drupal/Core/StackMiddleware/KernelPreHandle.php(47): Drupal\Core\StackMiddleware\Session->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #15 /var/www/html/web/core/modules/page_cache/src/StackMiddleware/PageCache.php(99): Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #16 /var/www/html/web/core/modules/page_cache/src/StackMiddleware/PageCache.php(78): Drupal\page_cache\StackMiddleware\PageCache->pass(Object(Symfony\Component\HttpFoundation\Request), 1, true) #17 /var/www/html/web/core/lib/Drupal/Core/StackMiddleware/ReverseProxyMiddleware.php(47): Drupal\page_cache\StackMiddleware\PageCache->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #18 /var/www/html/web/core/lib/Drupal/Core/StackMiddleware/NegotiationMiddleware.php(50): Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #19 /var/www/html/vendor/stack/builder/src/Stack/StackedHttpKernel.php(23): Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #20 /var/www/html/web/core/lib/Drupal/Core/DrupalKernel.php(657): Stack\StackedHttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #21 /var/www/html/web/index.php(19): Drupal\Core\DrupalKernel->handle(Object(Symfony\Component\HttpFoundation\Request)) #22 {main}.

CommentFileSizeAuthor
#2 uiplog_fix_admin_form_2955127_2.patch860 bytesnkoporec

Comments

nkoporec created an issue. See original summary.

nkoporec’s picture

Status: Active » Needs review
StatusFileSize
new860 bytes

This patch fixes the issue.

useernamee’s picture

Status: Needs review » Reviewed & tested by the community

Hi @nkoporec.
I have reproduced your issue and tested your patch. It applies and fixes the bug you pointed out.

*slightly offtopic: After some testing of module, I found out that after account deletion if you have set not to delete user IP username is lost and there is written only Anonymous (in reports for user IP). It might be a good feature to save usernames somewhere so there is a way to distinguish deleted accounts.

wtuvell’s picture

Hello guys (nkoporec & useernamee) —

I installed uiplog last week, hit the bug today, searched & found this report. I've installed the patch.

However, while the crash no longer happens, the patch doesn't "fix" the bug for me.

Specifically, what I'm trying to do is change some of the user account msgs (the ones at the bottom of .../admin/config/people/accounts). I type in the new/desired msg, and hit Save. Before installing that patch, the Save operation would crash. With the patch installed, the Save doesn't crash, but the operation doesn't succeed either: The configured msg reverts to the old one, not the new one I want.

Any ideas?

wtuvell’s picture

Follow-up:

Just to confirm, I uninstalled uiplog, and now everything works correctly, so the bug is in uiplog.

useernamee’s picture

Tested really quickly and I can confirm your issue. I can change the User IP on account delete option, but I can not change other settings.

useernamee’s picture

Status: Reviewed & tested by the community » Needs work
nkoporec’s picture

Hi,I think this issue is related to your problems...

useernamee’s picture

Status: Needs work » Needs review

You are right. After applying patch from the issue (2954984) you posted @nkoporec user admin form works again.

useernamee’s picture

Status: Needs review » Reviewed & tested by the community
Lsakurifaisu’s picture

I have the same issue as #7 after applying the patch. I uninstalled the module and was able to apply changes to /admin/config/people/accounts .

Lsakurifaisu’s picture

Apply the patch from #2 and following #8's link to another patch resulted in the correcting the functionality for me.

Lsakurifaisu’s picture

Apply the patch from #2 and following #8's link to another patch resulted in the correcting the functionality for me.

namitasaxena’s picture

@nkoporec #2 patch is not working properly, When you click on "Save configuration", error has removed but updates are not saved, it just refresh the page.

avpaderno’s picture

Status: Reviewed & tested by the community » Needs work

I am changing status as per previous comment.

sivaji_ganesh_jojodae’s picture

Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.