As a follow up to "Time to delete recently read is not configurable." issue, it should be good that beside the time based removal, we also create a count based removal of old items.

This means that we would have additional option on config page, where we can set the number of items we want to keep for each user/session. We can name it Count and add an input field with number of items.

This way we can make sure, that each user (no matter how old the record) has their recently read items.

Comments

boshtian created an issue. See original summary.

nkoporec’s picture

Status: Active » Needs review
StatusFileSize
new8.07 KB

Created a patch for this feature request.

useernamee’s picture

StatusFileSize
new3.78 KB

Hi @nkoporec.
Your patch does not apply after recent changes to dev version, so I have made some changes to your patch and now it applies.

useernamee’s picture

useernamee’s picture

StatusFileSize
new5.93 KB

I was a bit sloppy with my first patch so here is the new one.

I have tested your patch @nkoporec and I found you had a small problem in condition for deletion of recently_read entity. I have made correction. I have also changed the order of deletion and creation of new entity so that max count gets checked after new entity is created.

icurk’s picture

Status: Needs review » Reviewed & tested by the community

Nice catch @useernamee

  • boshtian committed 78c19d6 on 8.x-1.x authored by useernamee
    Issue #2954822 by useernamee, nkoporec, icurk: Add an option for count...
boshtian’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.