If you have an empty blacklist and select Add comma to blacklist, the validation doesn't work properly.It still allows adding the content title with a comma in it.If you add a blacklisted word then the Add comma works as expected.

Comments

nkoporec created an issue. See original summary.

nkoporec’s picture

Assigned: nkoporec » Unassigned
Status: Active » Needs review
StatusFileSize
new1.17 KB

Created a patch to fix this issue.

useernamee’s picture

Status: Needs review » Reviewed & tested by the community

I have reproduced this issue, applied your patch and issue is gone. Changing status to RTBC.

mashir’s picture

Status: Reviewed & tested by the community » Needs review
StatusFileSize
new1.65 KB
new1.15 KB

@nkoporec, thanks for the patch, but need to add the condition in both places (inside of the foreach loop as well). Attached patch for this and interdiff as well.

mahaveer003’s picture

Status: Needs review » Needs work
StatusFileSize
new102.78 KB

@Mashir, patch #4 is showing error while applying. I believe this is happening due to latest push of some code in Dev version. See attached screenshot .

error

mashir’s picture

Status: Needs work » Needs review
StatusFileSize
new1.7 KB

Patch attached with latest dev version code.

nkoporec’s picture

Status: Needs review » Reviewed & tested by the community

Nice catch @Mashir.Tested your last patch and it applies cleanly and also working as expected.Marking as RTBC.

  • mahaveer003 committed 4930d4e on 8.x-1.x authored by Mashir
    Issue #2954567 by Mashir, nkoporec, mahaveer003: Add coma to blacklist...
mahaveer003’s picture

Status: Reviewed & tested by the community » Fixed

Changes Pushed to the dev version. Thanks For the patch and review.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.