If you have an empty blacklist and select Add comma to blacklist, the validation doesn't work properly.It still allows adding the content title with a comma in it.If you add a blacklisted word then the Add comma works as expected.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | coma_blacklist-2954567-6.patch | 1.7 KB | mashir |
| #5 | patch_4_error.png | 102.78 KB | mahaveer003 |
| #4 | interdiff-2954567-2-4.txt | 1.15 KB | mashir |
| #4 | coma_blacklist-2954567-4.patch | 1.65 KB | mashir |
| #2 | node_title_validation_fix_add_comma_2954567_2.patch | 1.17 KB | nkoporec |
Comments
Comment #2
nkoporecCreated a patch to fix this issue.
Comment #3
useernamee commentedI have reproduced this issue, applied your patch and issue is gone. Changing status to RTBC.
Comment #4
mashir commented@nkoporec, thanks for the patch, but need to add the condition in both places (inside of the foreach loop as well). Attached patch for this and interdiff as well.
Comment #5
mahaveer003 commented@Mashir, patch #4 is showing error while applying. I believe this is happening due to latest push of some code in Dev version. See attached screenshot .
Comment #6
mashir commentedPatch attached with latest dev version code.
Comment #7
nkoporecNice catch @Mashir.Tested your last patch and it applies cleanly and also working as expected.Marking as RTBC.
Comment #9
mahaveer003 commentedChanges Pushed to the dev version. Thanks For the patch and review.