Edit Site is not showing the form for HTTPS when the site is on a web cluster.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | 2954350-cluster_site_edit_3.patch | 2.5 KB | bdragon |
Edit Site is not showing the form for HTTPS when the site is on a web cluster.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | 2954350-cluster_site_edit_3.patch | 2.5 KB | bdragon |
Comments
Comment #2
bdragon commentedStill doing internal testing on this as to whether more changes are necessary to get it working.
Comment #3
bdragon commentedOK, yeah, there's more going on here.
web_cluster and web_pack do compensation for the ssl_enabled property, but nothing for https.
Additionally, something is going wrong with the server variables -- they are not being propogated properly on web clusters, so attempting to enable https on a site is causing it to attempt to call scripts in /.
Going to investigate more.
Comment #4
bdragon commentedAn alternative way to fix would be to teach web pack and web cluster about the https_enabled. Trying that in #2954727: web_pack and web_cluster https_enabled not propogated.
Comment #5
bdragon commentedComing back to this patch, since it looks like the logic has to go in hosting_https anyway.
Comment #6
bdragon commentedSimplified patch by fixing hosting_https_get_servers() instead and checking whether the server is in the list instead of duplicating check code in multiple places.
Comment #7
bdragon commentedFor some reason, I have to enable certificate generation on the hostmaster for the actual certificate provisioning to work (even though the cluster that I'm actually running the test platform on does not include the hostmaster).
But other than that, deploying to clusters seems to operate OK.
Comment #8
helmo commentedThis looks ok
Comment #10
helmo commentedcommitted, thanks.