I tried to understand how this amazing module works for a few hours but got stuck because I wasn't able to re-add a field that I had deleted. I didn't even know it was possible to add that much other blocks in my layout!
Thanks to tim.plunkett I learnt that there was supposed to be an "Add Block" button in each area of the layouts then I found it hidden by AdBlock Plus. I know it's a third party problem but I don't know why it choosed to block this link (I have default settings)
It appears that AdBlock Plus does not like the "add-block" CSS class so we just have to change it.
Nope.
Nope.
Nope.
| Comment | File | Size | Author |
|---|---|---|---|
| #14 | screen-shot 2018-04-13 at 10.55.57 AM.png | 633.38 KB | utcwebdev |
| #9 | core-layout_builder_adblock-2953340-7.patch | 3.76 KB | WidgetsBurritos |
| #2 | core-layout_builder_adblock-2953340-2.patch | 1.36 KB | duaelfr |
| with_adblock.png | 24.98 KB | duaelfr | |
| without_adblock.png | 28.82 KB | duaelfr |
Comments
Comment #2
duaelfrSo... it seems that AdBlock does not like the "add-block" CSS class...
Comment #3
duaelfrComment #4
damienmckennaThis should be pretty painless :)
Comment #5
dyannenovaI haven't been able to replicate this one using AdBlock Plus, so it's hard for me to test, but I think we need to keep the class names between Add Block and Add Section consistent.
Comment #6
twiik commentedHappens for me with AdGuard in Chrome as well.
Comment #7
WidgetsBurritos commentedWorking on this at DrupalCon
Comment #8
WidgetsBurritos commentedComment #9
WidgetsBurritos commentedPer feedback in #5, this patch replaces all instances of
add-blocktonew-blockandadd-sectiontonew-section.Comment #10
WidgetsBurritos commentedComment #11
wgentry commentedWorking on this at DrupalCon2018
Comment #12
kporras07 commentedCode looks ok for me, but I can't reproduce initial error so I can't really test the patch
Comment #13
wgentry commentedUnable to replicate.
Comment #14
utcwebdev commentedI cannot replicate this issue with Mac High Sierra 10.13.4 (17E199) Safari Version 11.1 (13605.1.33.1.2)
Comment #15
tim.plunkettI think this is fine.
Comment #18
lauriiiI checked the easy list rules and it seems like there's some rules that are similar to the classnames we've used here, but I didn't find an exact match. Anyway, this seems fine since it fixes the problem. Committed 2ea71c6 and pushed to 8.6.x. Also 🍒picked 13bdff8 and pushed to 8.5.x. Thanks!
Comment #20
tim.plunkettRetroactively tagging
Comment #21
tim.plunkett