Hi there, I've updated the limited search feature option, so now it's can be globally managed in the main Select2Boxes admin form. Patch with updated tests is attached

CommentFileSizeAuthor
#10 limited_search_update_7.patch19.15 KBvalentine94
#9 limited_search_update_6.patch14.42 KBvalentine94
#7 limited_search_update_5.patch14.42 KBmatsbla
#6 limited_search_update_4.patch12.9 KBmatsbla
#5 limited_search_update_3.patch11.9 KBmatsbla
#3 limited_search_update_2.patch30.4 KBvalentine94
limited_search_update_1.patch30.4 KBvalentine94

Comments

Valentine94 created an issue. See original summary.

matsbla’s picture

matsbla commented

I think this patch introduce an issue when you want to add new terms to fields using the search bar.
With this patch it is not possible any longer.
Maybe it also needs a test to see if you can add a new term?

valentine94’s picture

valentine94
Location Kyiv, Ukraine
commented
StatusFileSize
new limited_search_update_2.patch30.4 KB

OK, there was a problem in a JS code, which throws the error and blocks the code to be further executed.

Updated a patch

Status: Needs review » Needs work

The last submitted patch, 3: limited_search_update_2.patch, failed testing. View results

matsbla’s picture

matsbla commented
StatusFileSize
new limited_search_update_3.patch11.9 KB

I removed readme file and css changes.

matsbla’s picture

matsbla commented
StatusFileSize
new limited_search_update_4.patch12.9 KB

Grouping settings for library and limit search box by length in form

matsbla’s picture

matsbla commented
StatusFileSize
new limited_search_update_5.patch14.42 KB

Also update readme file and correct data type for form and config shema

matsbla’s picture

matsbla commented
Status: Needs work » Needs review
valentine94’s picture

valentine94
Location Kyiv, Ukraine
commented
StatusFileSize
new limited_search_update_6.patch14.42 KB

Fixed small typo

valentine94’s picture

valentine94
Location Kyiv, Ukraine
commented
StatusFileSize
new limited_search_update_7.patch19.15 KB

Added tests for entity autocreation

valentine94’s picture

valentine94
Location Kyiv, Ukraine
commented
Status: Needs review » Needs work

Triggering test bot

valentine94’s picture

valentine94
Location Kyiv, Ukraine
commented
Status: Needs work » Needs review

Triggering test bot

matsbla’s picture

matsbla commented
Title: Limited search feature update » Make site wide config for limiting serach box visability by list length

Thanks, it works good!
Update title.

  • matsbla committed 36edfd5 on 8.x-1.x authored by Valentine94 
    Issue #2951941 by Valentine94, matsbla: Make site wide config for...
matsbla’s picture

matsbla commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.