Problem/Motivation

I'm doing a Drupal 6 to 8 upgrade and using the migrate_drupal_ui module. On the migration review form I see lots of errors like 

Notice: Undefined index: jquery_ui in Drupal\migrate_drupal_ui\Form\ReviewForm->buildForm() (line 240 of core/modules/migrate_drupal_ui/src/Form/ReviewForm.php).

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#8 2951684-2-8.patch2.46 KBalexpott
#8 3-8-interdiff.txt1.1 KBalexpott
#3 2951684-3.patch2.39 KBquietone
#3 2951684-3-fail.patch1.58 KBquietone
#2 2951684-2.patch823 bytesalexpott

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review
Issue tags: +Needs tests
StatusFileSize
new 2951684-2.patch823 bytes

The Drupal 6 site I'm migrating from has never seen the calendarsignup module but I'm getting notices about it. That's because it is not in the system table.

quietone’s picture

quietone commented
StatusFileSize
new 2951684-3-fail.patch1.58 KB
new 2951684-3.patch2.39 KB

Yes this fix makes sense. We should not assume that an extension listed in noUpgradePaths will have an entry in the source system table.

The last submitted patch, 3: 2951684-3-fail.patch, failed testing. View results

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Status: Needs review » Reviewed & tested by the community

Good test coverage. Fixes an error. Easy fix.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Issue tags: -Needs tests

We have tests.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented 
+++ b/core/modules/migrate_drupal_ui/tests/src/Functional/MigrateUpgradeReviewPageTestBase.php
@@ -112,6 +112,27 @@ public function testMigrateUpgradeReviewPage() {
+    // Check there are no errors when a module in noUpgradePaths is not in
+    // the source system tables. Test with a module that is listed in
+    // noUpgradePaths for both Drupal 6 and Drupal 7.

Not wrapping a column 80, looks great otherwise.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
StatusFileSize
new 3-8-interdiff.txt1.1 KB
new 2951684-2-8.patch2.46 KB

Fixing wrapping and adding an @see to be helpful.

  • plach committed fe1e9a5 on 8.6.x 
    Issue #2951684 by alexpott, quietone: Undefined index ReviewForm->...
plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Version: 8.6.x-dev » 8.5.x-dev

Committed fe1e9a5 and pushed to 8.6.x. Thanks!

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Status: Reviewed & tested by the community » Fixed

Committed df59fd8 and pushed to 8.5.x. Thanks!

  • plach committed df59fd8 on 8.5.x 
    Issue #2951684 by alexpott, quietone: Undefined index ReviewForm->...
plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented

Un-crediting myself...

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Version: 8.5.x-dev » 8.6.x-dev

Sorry about the line wrap. I was reviewing on mobile, and that is one of the few things its hard to catch.

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Version: 8.6.x-dev » 8.5.x-dev

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.