Closed (fixed)
Project:
Superfish Dropdown Menu
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
9 Mar 2018 at 06:47 UTC
Updated:
8 Aug 2023 at 08:59 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
MRPRAVIN commentedComment #5
vakulrai commentedMRPRAVIN,
I ran phpcs on my local it does not log any code errors.
Adding a patch for typehint array.
Comment #6
deepanker_bhalla commented@vakulrai Good work. I can confirm the patch #5 is applying cleanly. Here is the output:
❯ superfish 8.x-1.x* git apply -v coding-error-2951400.patch
Checking patch src/Plugin/Block/SuperfishBlock.php...
Applied patch src/Plugin/Block/SuperfishBlock.php cleanly.
❯ superfish 8.x-1.x* phpcs --standard=Drupal .
❯ superfish 8.x-1.x*
PHPCS is reporting no coding standard warning after applying the patch #5.
Comment #7
mehrpadin commentedHey there,
I think this was suggested before and I applied it and ran into the same error that I just did, thanks anyway.
Comment #8
mehrpadin commentedComment #9
nwom commentedI can confirm the same problem as #7 after applying the patch. The WSOD and error still occurs.
The error also only started occurring after I installed the following core patch (perhaps there are other ways to reproduce it): #3164389: Enforce block plugins returning an array
Comment #10
indrapatil commentedHi,
I fixed the coding standard issue
please review it.
Thanks
Comment #11
sourabhjainComment #12
nayana_mvr commentedVerified the patch #10 and tested it on Drupal version 10.1.x and Superfish version 8.x-1.x. The patch works fine and all the coding standard issues are fixed.
Comment #13
ivnishComment #15
lobsterr commented