Reviewing some of the main tasks that should be hit up before considering a full release.

Comments

Alan D. created an issue. See original summary.

alan d.’s picture

alan d. commented

Assessing the queue, only #2953849: Custom Name Options seems to be the last significant feature that will alter the API, blocking the first full release.

justanothermark’s picture

justanothermark commented

I'm not sure if holding up a full release for a new feature with little progress is worthwhile? Whether a full release or not, a new tagged release would be nice to have.

rosk0’s picture

rosk0
he/him
Primary language Russian
Location Wellington
commented
Issue summary: View changes

That is so true. It is definitely time for a new release.

rosk0’s picture

rosk0
he/him
Primary language Russian
Location Wellington
commented
Issue summary: View changes

Oops, sorry.

Can we please have RC2 tagged?

alan d.’s picture

alan d. commented

certainly

https://www.drupal.org/project/name/releases/8.x-1.0-rc2

one hard issue left in the todo list, not sure if I'll get there anytime soon.

#2953849: Custom Name Options

d.o should allow up/down-voting of issues, this one probably only affects a tiny handful of users, albeit it would nuke the old hacky approach that would always be beneficial (using vocabs for name options)

dropa’s picture

dropa commented

RC2 did not deliver upgrade paths for views, which it should.

Say you have few submodules, each providing views that does use name field, now after RC2, tests for those modules will break due to schema errors like following:

Drupal\Core\Config\Schema\SchemaIncompleteException: Schema errors for
views.view.my_view:display with the following errors:
views.view.my_view:display.default.display_options.fields.name__given.settings.markup
variable type is boolean but applied schema class is
Drupal\Core\TypedData\Plugin\DataType\StringData,
views.view.my_view:display.default.display_options.fields.name__given.settings.output
missing schema,
views.view.my_view:display.default.display_options.fields.name__given.settings.multiple
missing schema,
views.view.my_view:display.default.display_options.fields.name__given.settings.multiple_delimiter
missing schema,
views.view.my_view:display.default.display_options.fields.name__given.settings.multiple_and
missing schema,
views.view.my_view:display.default.display_options.fields.name__given.settings.multiple_delimiter_precedes_last
missing schema,
views.view.my_view:display.default.display_options.fields.name__given.settings.multiple_el_al_min
missing schema,
views.view.my_view:display.default.display_options.fields.name__given.settings.multiple_el_al_first
missing schema,
views.view.my_view:display.default.display_options.fields.name__family.settings.markup

Now in order to fix that, the view that is being provided by the module itself of course needs to be updated, but for each module to also provide update for existing view is not supposed to be required. Instead name module should provide that update.

Edit: the update itself should be quite easy, since re-saving the view from UI will actually fix the schema for given view.

Edit 2: It seems that just saving the view itself does not actually change everything that is necessary, saving the corresponding fields individually will also change things.

alan d.’s picture

alan d. commented

Thanks for reporting, I created a corresponding issue here: #3069111: View schema upgrade required

@Dropa
If just tests that are failing, that issue can stay as minor, but if other things are breaking, that issue should be bumped to normal or major.

bluegeek9’s picture

bluegeek9 commented
Status: Active » Closed (outdated)

Name 8.x-1.0 has been released. I am closing this as outdated.