Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
Noticed that the documentation on this test method is incorrect, referring to d6 and not d7 and might be nice to not use the term 'builder' or at least expand on it.
/**
* Tests d6_profile_values builder.
*
* Ensures profile fields are merged into the d6_profile_values migration's
* process pipeline.
*/
public function testClass() {
$migration = $this->getMigration('d7_user');
/** @var \Drupal\migrate\Plugin\MigrationInterface[] $migrations */
$this->assertIdentical('d7_user', $migration->id());
$process = $migration->getProcess();
$this->assertIdentical('field_file', $process['field_file'][0]['source']);
}
Proposed resolution
Fix the documention
Remaining tasks
Write a patch
review
commit
Comment | File | Size | Author |
---|---|---|---|
#6 | 2949555-6.patch | 781 bytes | quietone |
#2 | Incorrect-documentation-2949555-2.patch | 618 bytes | ankitjain28may |
Comments
Comment #2
ankitjain28may CreditAttribution: ankitjain28may as a volunteer and at Google Summer of Code commentedFixed the documentation..
Comment #3
quietone CreditAttribution: quietone as a volunteer commented@ankitjain28may, thanks for making the patch. Off to a good start but this one takes some knowledge of migration and that is why I didn't mark it as novice. Keen to have another try? I should be able to review it tomorrow,
This isn't testing the d7 profile_values. It is actually testing that the process for the profile values is added to the migration process pipeline. Now how to put that in a summary line? Maybe 'Tests that the profile value process is added to the pipeline'. Hopefully that is less than 80 characters.
Still referring to d6 here.
Comment #4
heddnComment #6
quietone CreditAttribution: quietone as a volunteer commentedFixes for all the items in #3. No interdiff since this is a small patch.
Comment #7
quietone CreditAttribution: quietone as a volunteer commentedComment #8
Anonymous (not verified) CreditAttribution: Anonymous commentedComment #9
alexpottCommitted and pushed f06b97e218 to 8.7.x and 7f7ad644f0 to 8.6.x. Thanks!