Problem/Motivation

Noticed that the documentation on this test method is incorrect, referring to d6 and not d7 and might be nice to not use the term 'builder' or at least expand on it.

  /**
   * Tests d6_profile_values builder.
   *
   * Ensures profile fields are merged into the d6_profile_values migration's
   * process pipeline.
   */
  public function testClass() {
    $migration = $this->getMigration('d7_user');
    /** @var \Drupal\migrate\Plugin\MigrationInterface[] $migrations */
    $this->assertIdentical('d7_user', $migration->id());
    $process = $migration->getProcess();
    $this->assertIdentical('field_file', $process['field_file'][0]['source']);
  }

Proposed resolution

Fix the documention

Remaining tasks

Write a patch
review
commit

CommentFileSizeAuthor
#6 2949555-6.patch781 bytesquietone
#2 Incorrect-documentation-2949555-2.patch618 bytesankitjain28may

Comments

quietone created an issue. See original summary.

ankitjain28may’s picture

ankitjain28may commented
Status: Active » Needs review
StatusFileSize
new Incorrect-documentation-2949555-2.patch618 bytes

Fixed the documentation..

quietone’s picture

quietone commented

@ankitjain28may, thanks for making the patch. Off to a good start but this one takes some knowledge of migration and that is why I didn't mark it as novice. Keen to have another try? I should be able to review it tomorrow,

  1. +++ b/core/modules/user/tests/src/Kernel/Migrate/d7/UserMigrationClassTest.php
@@ -12,7 +12,7 @@
+   * Tests d7_profile_values.

    This isn't testing the d7 profile_values. It is actually testing that the process for the profile values is added to the migration process pipeline. Now how to put that in a summary line? Maybe 'Tests that the profile value process is added to the pipeline'. Hopefully that is less than 80 characters. 

  2. +++ b/core/modules/user/tests/src/Kernel/Migrate/d7/UserMigrationClassTest.php
@@ -12,7 +12,7 @@
    * Ensures profile fields are merged into the d6_profile_values migration's

    Still referring to d6 here.

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Needs review » Needs work

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

quietone’s picture

quietone commented
Status: Needs work » Needs review
StatusFileSize
new 2949555-6.patch781 bytes

Fixes for all the items in #3. No interdiff since this is a small patch.

quietone’s picture

quietone commented
Title: Incorrect documentation on method UserMigrationClassTest » Correct the documentation on method UserMigrationClassTest
Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed f06b97e218 to 8.7.x and 7f7ad644f0 to 8.6.x. Thanks!

  • alexpott committed f06b97e on 8.7.x 
    Issue #2949555 by quietone, ankitjain28may: Correct the documentation on...

  • alexpott committed 7f7ad64 on 8.6.x 
    Issue #2949555 by quietone, ankitjain28may: Correct the documentation on...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.