Problem/Motivation

Symfony 3.4.5 is out. We need to move at least the yaml component to it because of a bug - see #2945275: Remove hack to fix bug in symfony/yaml

Proposed resolution

Update the components.

Remaining tasks

User interface changes

None

API changes

None - bug fixes only.

Data model changes

None

CommentFileSizeAuthor
#7 2949225-7.patch22.18 KBalexpott
#3 2949225-3.patch26.58 KBalexpott
#3 2-3-interdiff.txt458 bytesalexpott
#2 2949225-2.patch26.13 KBalexpott

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review
StatusFileSize
new 2949225-2.patch26.13 KB
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
StatusFileSize
new 2-3-interdiff.txt458 bytes
new 2949225-3.patch26.58 KB

Hmmm... also need to update the constraint we are not compatible with anything lower than Symfony\Yaml 3.4.5

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs review » Postponed

Postponing on #2945275: Remove hack to fix bug in symfony/yaml

catch’s picture

catch
he/him
Primary language English
commented
Status: Postponed » Needs review

Just committed the other issue.

zymbian’s picture

zymbian commented
Status: Needs review » Reviewed & tested by the community

Patch looks good to me. Marking RTBC.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
StatusFileSize
new 2949225-7.patch22.18 KB

Rebased patch on HEAD.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Closed (duplicate)

Closed in favour of #2951269: Update symfony/* and twig/twig because there's been another 3.4 bug fix release. Although that issue was actually the duplicate one.